address comment: update to allowed username

Author: blva

src/tools/args.ts

@@ -3,8 +3,8 @@ import { z, type ZodString } from "zod";
 const NO_UNICODE_REGEX = /^[\x20-\x7E]*$/;
 export const NO_UNICODE_ERROR = "String cannot contain special characters or Unicode symbols";
 
-const ALLOWED_NAME_CHARACTERS_REGEX = /^[a-zA-Z0-9._-]+$/;
-export const ALLOWED_NAME_CHARACTERS_ERROR = " can only contain letters, numbers, dots, hyphens, and underscores";
+const ALLOWED_USERNAME_CHARACTERS_REGEX = /^[a-zA-Z0-9._-]+$/;
+export const ALLOWED_USERNAME_CHARACTERS_ERROR = " can only contain letters, numbers, dots, hyphens, and underscores";
 
 const ALLOWED_REGION_CHARACTERS_REGEX = /^[a-zA-Z0-9_-]+$/;
 export const ALLOWED_REGION_CHARACTERS_ERROR = "Region can only contain letters, numbers, hyphens, and underscores";
@@ -51,7 +51,7 @@ export const AtlasArgs = {
             .string()
             .min(1, "Username is required")
             .max(100, "Username must be 100 characters or less")
-            .regex(ALLOWED_NAME_CHARACTERS_REGEX, "Username " + ALLOWED_NAME_CHARACTERS_ERROR),
+            .regex(ALLOWED_USERNAME_CHARACTERS_REGEX, "Username " + ALLOWED_USERNAME_CHARACTERS_ERROR),
 
     ipAddress: (): z.ZodString => z.string().ip({ version: "v4" }),
 

tests/unit/args.test.ts

@@ -3,7 +3,7 @@ import {
     AtlasArgs,
     CommonArgs,
     ALLOWED_PROJECT_NAME_CHARACTERS_ERROR,
-    ALLOWED_NAME_CHARACTERS_ERROR,
+    ALLOWED_USERNAME_CHARACTERS_ERROR,
     ALLOWED_REGION_CHARACTERS_ERROR,
     ALLOWED_CLUSTER_NAME_CHARACTERS_ERROR,
     NO_UNICODE_ERROR,
@@ -195,8 +195,8 @@ describe("Tool args", () => {
                 expect(() => schema.parse(longUsername)).toThrow("Username must be 100 characters or less");
 
                 // Invalid characters
-                expect(() => schema.parse("user@name")).toThrow("Username " + ALLOWED_NAME_CHARACTERS_ERROR);
-                expect(() => schema.parse("user name")).toThrow("Username " + ALLOWED_NAME_CHARACTERS_ERROR);
+                expect(() => schema.parse("user@name")).toThrow("Username " + ALLOWED_USERNAME_CHARACTERS_ERROR);
+                expect(() => schema.parse("user name")).toThrow("Username " + ALLOWED_USERNAME_CHARACTERS_ERROR);
             });
 
             it("should accept exactly 100 characters", () => {
@@ -402,7 +402,7 @@ describe("Tool args", () => {
             expect(() => AtlasArgs.username().parse("a".repeat(101))).toThrow(
                 "Username must be 100 characters or less"
             );
-            expect(() => AtlasArgs.username().parse("invalid name")).toThrow("Username " + ALLOWED_NAME_CHARACTERS_ERROR);
+            expect(() => AtlasArgs.username().parse("invalid name")).toThrow("Username " + ALLOWED_USERNAME_CHARACTERS_ERROR);
         });
     });
 });