chore: fix tests

Author: gagik

src/common/search/vectorSearchEmbeddingsManager.ts

@@ -105,7 +105,7 @@ export class VectorSearchEmbeddingsManager {
         }
     }
 
-    private async findFieldsWithWrongEmbeddings(
+    public async findFieldsWithWrongEmbeddings(
         {
             database,
             collection,

src/tools/mongodb/create/insertMany.ts

@@ -28,7 +28,7 @@ export class InsertManyTool extends MongoDBToolBase {
         embeddingParameters: zSupportedEmbeddingParametersWithInput
             .optional()
             .describe(
-                "The embedding model and its parameters to use to generate embeddings for fields that have vector search indexes. When a field has a vector search index and contains a plain text string in the document, embeddings will be automatically generated from that string value. Note to LLM: If unsure which embedding model to use, ask the user before providing one."
+                "The embedding model and its parameters to use to generate embeddings for fields with vector search indexes. Note to LLM: If unsure which embedding model to use, ask the user before providing one."
             ),
     };
     public operationType: OperationType = "create";

tests/unit/common/search/vectorSearchEmbeddingsManager.test.ts

@@ -1,4 +1,4 @@
-import { describe, it, expect, vi, beforeEach } from "vitest";
+import { describe, it, expect, vi, beforeEach, afterEach } from "vitest";
 import type { MockedFunction } from "vitest";
 import { VectorSearchEmbeddingsManager } from "../../../../src/common/search/vectorSearchEmbeddingsManager.js";
 import type {
@@ -411,20 +411,65 @@ describe("VectorSearchEmbeddingsManager", () => {
             );
         });
 
-        describe("when atlas search is not available", () => {
+        describe("assertVectorSearchIndexExists", () => {
             beforeEach(() => {
                 embeddings = new VectorSearchEmbeddingsManager(
                     embeddingValidationEnabled,
                     connectionManager,
                     new Map(),
                     getMockedEmbeddingsProvider
                 );
+            });
+
+            afterEach(() => {
+                provider.getSearchIndexes.mockReset();
+            });
+
+            it("does not throw an exception when index is available for path", async () => {
+                provider.getSearchIndexes.mockResolvedValue([
+                    {
+                        id: "65e8c766d0450e3e7ab9855f",
+                        name: "vector-search-test",
+                        type: "vectorSearch",
+                        status: "READY",
+                        queryable: true,
+                        latestDefinition: {
+                            fields: [
+                                {
+                                    type: "vector",
+                                    path: embeddingToGenerate.path,
+                                    numDimensions: 1024,
+                                    similarity: "euclidean",
+                                },
+                            ],
+                        },
+                    },
+                ]);
+                await expect(
+                    embeddings.assertVectorSearchIndexExists({
+                        database,
+                        collection,
+                        path: embeddingToGenerate.path,
+                    })
+                ).resolves.not.toThrowError();
+            });
 
+            it("throws an exception when atlas search is not available", async () => {
                 provider.getSearchIndexes.mockRejectedValue(new Error());
+                await expect(
+                    embeddings.assertVectorSearchIndexExists({
+                        database,
+                        collection,
+                        path: embeddingToGenerate.path,
+                    })
+                ).rejects.toThrowError();
             });
 
-            it("throws an exception", async () => {
-                await expect(embeddings.generateEmbeddings(embeddingToGenerate)).rejects.toThrowError();
+            it("throws an exception when no index is available for path", async () => {
+                provider.getSearchIndexes.mockResolvedValue([]);
+                await expect(
+                    embeddings.assertVectorSearchIndexExists({ database, collection, path: embeddingToGenerate.path })
+                ).rejects.toThrowError();
             });
         });
 
@@ -459,12 +504,6 @@ describe("VectorSearchEmbeddingsManager", () => {
                     );
                 });
 
-                describe("when no index is available for path", () => {
-                    it("throws an exception", async () => {
-                        await expect(embeddings.generateEmbeddings(embeddingToGenerate)).rejects.toThrowError();
-                    });
-                });
-
                 describe("when index is available on path", () => {
                     beforeEach(() => {
                         provider.getSearchIndexes.mockResolvedValue([