fixes and add test

Author: blva

src/telemetry/telemetry.ts

@@ -1,5 +1,5 @@
 import type { Session } from "../common/session.js";
-import type { BaseEvent, CommonProperties, TelemetryEvent } from "./types.js";
+import type { BaseEvent, CommonProperties } from "./types.js";
 import type { UserConfig } from "../common/config.js";
 import { LogId } from "../common/logger.js";
 import type { ApiClient } from "../common/atlas/apiClient.js";
@@ -80,7 +80,7 @@ export class Telemetry {
         const [deviceIdValue, containerEnv] = await this.setupPromise;
 
         this.commonProperties.device_id = deviceIdValue;
-        this.commonProperties.is_container_env = containerEnv;
+        this.commonProperties.is_container_env = containerEnv ? "true" : "false";
 
         this.isBufferingEvents = false;
     }

src/telemetry/types.ts

@@ -97,7 +97,7 @@ export type CommonProperties = {
     /**
      * A boolean indicating whether the server is running in a container environment.
      */
-    is_container_env?: boolean;
+    is_container_env?: TelemetryBoolSet;
 
     /**
      * The version of the MCP client as reported by the client on session establishment.

tests/integration/telemetry.test.ts

@@ -36,4 +36,32 @@ describe("Telemetry", () => {
         expect(telemetry.getCommonProperties().device_id).toBe(actualDeviceId);
         expect(telemetry["isBufferingEvents"]).toBe(false);
     });
+
+    it("should redact sensitive data", async () => {
+        const logger = new CompositeLogger();
+        const deviceId = DeviceId.create(logger);
+
+        // configure keychain with a secret that would show up in random properties
+        const keychain = new Keychain();
+        keychain.register(process.platform, "url");
+
+        const telemetry = Telemetry.create(
+            new Session({
+                apiBaseUrl: "",
+                logger,
+                exportsManager: ExportsManager.init(config, logger),
+                connectionManager: new MCPConnectionManager(config, driverOptions, logger, deviceId),
+                keychain: keychain,
+            }),
+            config,
+            deviceId
+        );
+
+        await telemetry.setupPromise;
+
+        // expect the platform to be redacted
+        const commonProperties = telemetry.getCommonProperties();
+        expect(commonProperties.platform).toBe("<url>");
+        expect(telemetry["isBufferingEvents"]).toBe(false);
+    });
 });