Skip to content

Commit dd80fc1

Browse files
committed
address comment: add unref
1 parent a14e534 commit dd80fc1

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

src/telemetry/telemetry.ts

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -96,16 +96,17 @@ export class Telemetry {
9696
// Wait up to 5 seconds for events to be sent before closing, but don't throw if it times out
9797
const flushTimeout = 5000;
9898
await Promise.race([
99-
new Promise<void>((resolve) =>
100-
setTimeout(() => {
99+
new Promise<void>((resolve) => {
100+
const timeout = setTimeout(() => {
101101
this.session.logger.debug({
102102
id: LogId.telemetryClose,
103103
message: `Failed to flush remaining events within ${flushTimeout}ms timeout`,
104104
context: "telemetry",
105105
});
106106
resolve();
107-
}, flushTimeout)
108-
),
107+
}, flushTimeout);
108+
timeout.unref();
109+
}),
109110
this.emit([]),
110111
]);
111112
}

0 commit comments

Comments
 (0)