Skip to content

Commit e30b314

Browse files
chore: use env vars for mongo namespace
1 parent a53da61 commit e30b314

File tree

4 files changed

+10
-3
lines changed

4 files changed

+10
-3
lines changed

.github/workflows/accuracy-tests.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,8 @@ jobs:
2525
MDB_AZURE_OPEN_AI_API_KEY: ${{ secrets.ACCURACY_AZURE_OPEN_AI_API_KEY }}
2626
MDB_AZURE_OPEN_AI_API_URL: ${{ vars.ACCURACY_AZURE_OPEN_AI_API_URL }}
2727
MDB_ACCURACY_MDB_URL: ${{ secrets.ACCURACY_MDB_CONNECTION_STRING }}
28+
MDB_ACCURACY_MDB_DB: ${{ vars.ACCURACY_MDB_DB }}
29+
MDB_ACCURACY_MDB_COLLECTION: ${{ vars.ACCURACY_MDB_COLLECTION }}
2830
MDB_ACCURACY_BASELINE_COMMIT: ${{ github.event.pull_request.base.sha || '' }}
2931
steps:
3032
- uses: GitHubSecurityLab/actions-permissions/monitor@v1

scripts/accuracy/run-accuracy-tests.sh

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ export MDB_ACCURACY_RUN_ID=$(npx uuid v4)
1010

1111
# For providing a mongodb based storage to store accuracy result
1212
# export MDB_ACCURACY_MDB_URL=""
13+
# export MDB_ACCURACY_MDB_DB=""
14+
# export MDB_ACCURACY_MDB_COLLECTION=""
1315

1416
# By default we run all the tests under tests/accuracy folder unless a path is
1517
# specified in the command line. Such as:

tests/accuracy/sdk/accuracy-result-storage/get-accuracy-result-storage.ts

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,9 @@ import { MongoDBBasedResultStorage } from "./mongodb-storage.js";
33
import { AccuracyResultStorage } from "./result-storage.js";
44

55
export function getAccuracyResultStorage(): AccuracyResultStorage {
6-
if (process.env.MDB_ACCURACY_MDB_URL) {
7-
return new MongoDBBasedResultStorage(process.env.MDB_ACCURACY_MDB_URL);
6+
const { MDB_ACCURACY_MDB_URL, MDB_ACCURACY_MDB_DB, MDB_ACCURACY_MDB_COLLECTION } = process.env;
7+
if (MDB_ACCURACY_MDB_URL && MDB_ACCURACY_MDB_DB && MDB_ACCURACY_MDB_COLLECTION) {
8+
return new MongoDBBasedResultStorage(MDB_ACCURACY_MDB_URL, MDB_ACCURACY_MDB_DB, MDB_ACCURACY_MDB_COLLECTION);
89
}
910
return new DiskBasedResultStorage();
1011
}

tests/accuracy/sdk/accuracy-result-storage/mongodb-storage.ts

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,11 +13,13 @@ export class MongoDBBasedResultStorage implements AccuracyResultStorage {
1313

1414
constructor(
1515
connectionString: string,
16+
database: string,
17+
collection: string,
1618
// Omitting these as they might contain large chunk of texts
1719
private readonly omittedModelResponseFields: (keyof ModelResponse)[] = ["messages", "text"]
1820
) {
1921
this.client = new MongoClient(connectionString);
20-
this.resultCollection = this.client.db("mongodb-mcp-server").collection<AccuracyResult>("accuracy-results");
22+
this.resultCollection = this.client.db(database).collection<AccuracyResult>(collection);
2123
}
2224

2325
async getAccuracyResult(commitSHA: string, runId?: string): Promise<AccuracyResult | null> {

0 commit comments

Comments
 (0)