chore: add arg validation test coverage #570
Draft
+300
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Copilot <[email protected]>
There was a problem hiding this comment.
Pull Request Overview
This PR focuses on adding comprehensive argument validation test coverage across Atlas tools while refactoring test infrastructure for better organization. The changes introduce common validation patterns and enable running some tests without Atlas credentials.
Key changes:
- Adds standardized argument validation tests for Atlas tools using shared test helpers
- Refactors Atlas test helpers to separate credential-dependent tests from metadata validation
- Introduces common argument validation patterns and reusable parameter definitions
Reviewed Changes
Copilot reviewed 19 out of 25 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Adds new test project for Atlas cleanup scripts and excludes scripts directory |
| tests/integration/tools/atlas/*.test.ts | Adds argument validation tests and wraps credential-dependent tests |
| tests/integration/helpers.ts | Adds common validation argument sets and parameter definitions |
| src/tools/atlas/*.ts | Refactors to use shared argument definitions from args.ts |
| src/tools/args.ts | Adds shared argument objects and improves descriptions |
| scripts/cleanupAtlasTestLeftovers.test.ts | New cleanup script for stale Atlas test resources |
| package.json | Adds new npm script for Atlas cleanup |
| .github/workflows/cleanup-atlas-env.yml | Adds GitHub workflow for automated Atlas environment cleanup |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist