chore: use redact by default #624
Merged
+100
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the mongodb-redact library to automatically redact sensitive data from telemetry events before transmission. The changes ensure that any secrets registered in the keychain are properly masked in telemetry data to prevent accidental exposure of sensitive information.
- Implements redaction of telemetry properties using the
mongodb-redactlibrary and keychain secrets - Updates telemetry types to use string values instead of booleans for consistent redaction handling
- Adds comprehensive test coverage for redaction functionality across various telemetry properties
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/telemetry/telemetry.ts |
Integrates mongodb-redact to automatically redact sensitive data from telemetry events using keychain secrets |
src/telemetry/types.ts |
Updates boolean telemetry properties to use TelemetryBoolSet for consistent string-based redaction |
src/server.ts |
Converts boolean read_only_mode property to string format for telemetry consistency |
tests/unit/telemetry.test.ts |
Adds comprehensive test coverage for redaction functionality across static and dynamic properties |
Pull Request Test Coverage Report for Build 18352375577Details
💛 - Coveralls |
Co-authored-by: Copilot <[email protected]>
nirinchev
approved these changes
Oct 8, 2025
kmruiz
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Checklist