Merge pull request Automattic#14993 from Automattic/vkarpov15/bulksave-writeerrors

fix(model): avoid throwing TypeError if bulkSave()'s bulkWrite() fails with a non-BulkWriteError

Author: vkarpov15

lib/model.js

@@ -10,6 +10,7 @@ const Document = require('./document');
 const DocumentNotFoundError = require('./error/notFound');
 const EventEmitter = require('events').EventEmitter;
 const Kareem = require('kareem');
+const { MongoBulkWriteError } = require('mongodb');
 const MongooseBulkWriteError = require('./error/bulkWriteError');
 const MongooseError = require('./error/index');
 const ObjectParameterError = require('./error/objectParameter');
@@ -3417,6 +3418,11 @@ Model.bulkSave = async function bulkSave(documents, options) {
     (err) => ({ bulkWriteResult: null, bulkWriteError: err })
   );
 
+  // If not a MongoBulkWriteError, treat this as all documents failed to save.
+  if (bulkWriteError != null && !(bulkWriteError instanceof MongoBulkWriteError)) {
+    throw bulkWriteError;
+  }
+
   const matchedCount = bulkWriteResult?.matchedCount ?? 0;
   const insertedCount = bulkWriteResult?.insertedCount ?? 0;
   if (writeOperations.length > 0 && matchedCount + insertedCount < writeOperations.length && !bulkWriteError) {