requested changes 3

Author: aditi-khare-mongoDB

docs/schematypes.md

@@ -680,12 +680,12 @@ call it and assign the returned value to the path.
 The values `null` and `undefined` are not cast.
 
 The following inputs will result will all result in a [CastError](validation.html#cast-errors) once validated, meaning that it will not throw on initialization, only when validated:
-- NaN
-- strings that cast to NaN
-- objects that don't have a `valueOf()` function
-- a decimal that must be rounded to be an integer
-- an input that represents a value beyond the bounds of an 32-bit integer
 
+* NaN
+* strings that cast to NaN
+* objects that don't have a `valueOf()` function
+* a decimal that must be rounded to be an integer
+* an input that represents a value outside the bounds of an 32-bit integer
 
 ## Getters {#getters}
 

lib/cast/int32.js

@@ -9,7 +9,7 @@ const BSON = require('bson');
  *
  * @param {Any} value
  * @return {Number}
- * @throws {Error} if `value` does not represent an integer, or is beyond the bounds of an 32-bit integer.
+ * @throws {Error} if `value` does not represent an integer, or is outside the bounds of an 32-bit integer.
  * @api private
  */
 

lib/types/index.js

@@ -14,7 +14,6 @@ exports.Embedded = require('./arraySubdocument');
 exports.DocumentArray = require('./documentArray');
 exports.Decimal128 = require('./decimal128');
 exports.ObjectId = require('./objectid');
-exports.Int32 = require('./int32');
 
 exports.Map = require('./map');
 

lib/types/int32.js

@@ -27,7 +27,7 @@ describe('Int32', function() {
   });
 
   describe('supports the required property', function() {
-    it('when value is null', async function() {
+    it('when vaglue is null', async function() {
       const schema = new Schema({
         int32: {
           type: Schema.Types.Int32,
@@ -182,18 +182,6 @@ describe('Int32', function() {
       assert.strictEqual(doc.myInt, -997);
     });
 
-    it('casts from Mongoose Schema.Types.Int32', function() {
-      const schema = new Schema({
-        myInt: Schema.Types.Int32
-      });
-      const Test = mongoose.model('Test', schema);
-
-      const doc = new Test({
-        myInt: new mongoose.Types.Int32(53)
-      });
-      assert.strictEqual(doc.myInt, 53);
-    });
-
     it('casts from BSON.Long provided its value is within bounds of Int32', function() {
       const schema = new Schema({
         myInt: Schema.Types.Int32
@@ -393,7 +381,7 @@ describe('Int32', function() {
       mongoose.Schema.Types.Int32.cast(defaultCast);
     });
 
-    it('supports cast disabled', () => {
+    it('supports cast disabled', async() => {
       mongoose.Schema.Types.Int32.cast(false);
       const schema = new Schema({
         myInt1: {
@@ -405,11 +393,15 @@ describe('Int32', function() {
       });
       const Test = mongoose.model('Test', schema);
       const doc = new Test({
-        myInt: '52',
+        myInt1: '52',
         myInt2: 52
       });
       assert.strictEqual(doc.myInt1, undefined);
       assert.strictEqual(doc.myInt2, 52);
+
+      const err = await doc.validate().catch(e => e);
+      assert.ok(err);
+      assert.ok(err.errors['myInt1']);
     });
 
     it('supports custom cast', () => {

test/int32.test.js

@@ -425,9 +425,6 @@ export function autoTypedSchema() {
     decimal1?: Types.Decimal128 | null;
     decimal2?: Types.Decimal128 | null;
     decimal3?: Types.Decimal128 | null;
-    int32_1?: Types.Int32 | null;
-    int32_2?: Types.Int32 | null;
-    int32_3?: Types.Int32 | null;
   };
 
   const TestSchema = new Schema({
@@ -474,10 +471,7 @@ export function autoTypedSchema() {
     array8: { type: [String], default: () => undefined },
     decimal1: Schema.Types.Decimal128,
     decimal2: 'Decimal128',
-    decimal3: 'decimal128',
-    int32_1: Schema.Types.Int32,
-    int32_2: 'Int32',
-    int32_3: 'int32'
+    decimal3: 'decimal128'
   });
 
   type InferredTestSchemaType = InferSchemaType<typeof TestSchema>;

test/types/schema.test.ts

@@ -60,8 +60,6 @@ declare module 'mongoose' {
 
     class Decimal128 extends mongodb.Decimal128 { }
 
-    class Int32 extends mongodb.Int32 { }
-
     class DocumentArray<T> extends Types.Array<T extends Types.Subdocument ? T : Types.Subdocument<InferId<T>, any, T> & T> {
       /** DocumentArray constructor */
       constructor(values: AnyObject[]);