Merge pull request Automattic#15207 from Automattic/vkarpov15/Automatticgh-15192

fix(document): allow setting values to undefined with set(obj) syntax with strict: false

Author: vkarpov15

lib/document.js

@@ -1147,7 +1147,7 @@ Document.prototype.$set = function $set(path, val, type, options) {
         } else if (pathtype === 'nested' && valForKey == null) {
           this.$set(pathName, valForKey, constructing, options);
         }
-      } else if (valForKey !== void 0) {
+      } else {
         this.$set(pathName, valForKey, constructing, options);
       }
     }

test/document.test.js

@@ -7363,6 +7363,27 @@ describe('document', function() {
     assert.strictEqual(obj.subDoc.timestamp, date);
   });
 
+  it('supports setting values to undefined with strict: false (gh-15192)', async function() {
+    const helloSchema = new mongoose.Schema({
+      name: { type: String, required: true },
+      status: { type: Boolean, required: true },
+      optional: { type: Number }
+    }, { strict: false });
+    const Hello = db.model('Test', helloSchema);
+
+    const obj = new Hello({ name: 'abc', status: true, optional: 1 });
+    const doc = await obj.save();
+
+    doc.set({ optional: undefined });
+
+    assert.ok(doc.isModified());
+
+    await doc.save();
+
+    const { optional } = await Hello.findById(doc._id).orFail();
+    assert.strictEqual(optional, undefined);
+  });
+
   it('handles .set() on doc array within embedded discriminator (gh-7656)', function() {
     const pageElementSchema = new Schema({
       type: { type: String, required: true }