Skip to content

Commit 01997ab

Browse files
authored
chore(build): skip attempted PGP signing for now (#1174)
1 parent d85988b commit 01997ab

File tree

2 files changed

+10
-4
lines changed

2 files changed

+10
-4
lines changed

packages/build/src/run-draft.spec.ts

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -68,15 +68,17 @@ describe('draft', () => {
6868
});
6969

7070
it('asks the notary service to sign files', () => {
71-
expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
71+
// expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
7272
});
7373

7474
it('uploads artifacts to download center', () => {
75-
expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
75+
expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
76+
// expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
7677
});
7778

7879
it('uploads the artifacts to the github release', () => {
79-
expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
80+
expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
81+
// expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
8082
});
8183
});
8284

packages/build/src/run-draft.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,8 @@ export async function runDraft(
4444
tmpDir
4545
);
4646

47+
/*
48+
// pending https://jira.mongodb.org/browse/BUILD-14385
4749
await notarizeArtifact(
4850
tarballFile.path,
4951
{
@@ -53,10 +55,12 @@ export async function runDraft(
5355
}
5456
);
5557
const signatureFile = tarballFile.path + '.sig';
58+
*/
59+
void notarizeArtifact;
5660

5761
await Promise.all([
5862
[ downloadedArtifact, tarballFile.contentType ],
59-
[ signatureFile, 'application/pgp-signature' ]
63+
// [ signatureFile, 'application/pgp-signature' ]
6064
].flatMap(([ path, contentType ]) => [
6165
uploadToDownloadCenter(
6266
path,

0 commit comments

Comments
 (0)