feat(cli-repl): upgrade Node.js to v14.x MONGOSH-438 (#452)

Author: addaleax

.evergreen.yml

@@ -1,5 +1,4 @@
 set -e
-export NODE_JS_VERSION='12.18.4'
 export NVM_DIR="$HOME/.nvm"
 
 curl -o- https://raw.githubusercontent.com/nvm-sh/nvm/v0.35.3/install.sh | bash

.evergreen/.install_node

@@ -1,5 +1,4 @@
 set -e
-export NODE_JS_VERSION='12.18.4'
 export NVM_DIR="$HOME/.nvm"
 echo "Setting NVM environment home: $NVM_DIR"
 [ -s "$NVM_DIR/nvm.sh" ] && \. "$NVM_DIR/nvm.sh"

.evergreen/.setup_env

@@ -1,4 +1,4 @@
-$version = "12.18.4"
+$version = "$Env:NODE_JS_VERSION"
 $url = "https://nodejs.org/download/release/v$version/node-v$version-win-x64.zip"
 $filename = "node.zip"
 $node_zip = "$PSScriptRoot\$filename"

.evergreen/InstallNode.ps1

@@ -1,6 +1,5 @@
-$version = "12.18.4"
+$version = "$Env:NODE_JS_VERSION"
 $Env:PATH = "$PSScriptRoot\node-v$version-win-x64;C:\Python39\Scripts;C:\Python39;C:\Program Files\Git\mingw32\libexec\git-core;$Env:PATH"
-$Env:NODE_JS_VERSION = "$version"
 
 echo "Using node version:"
 node --version

.evergreen/SetupEnv.ps1

@@ -18,3 +18,13 @@ MongoDB welcomes community contributions! If you’re interested in making a con
 You can report new bugs by
 [creating a new issue](https://jira.mongodb.org/browse/MONGOSH/).
 Please include as much information as possible about your environment.
+
+## Node.js versions
+
+We support Node.js 12.x+ for the individual packages, and Node.js 14.x only for
+the CLI repl specifically. These versions are mentioned:
+
+- In the individual packages’ package.json files
+- In the evergreen config
+- In the homebrew generation script
+- In the Docker files we use for building the binary/testing vscode

CONTRIBUTING.md

@@ -32,7 +32,7 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=12.4.0"
+    "node": ">=14.15.0"
   },
   "dependencies": {
     "@mongosh/autocomplete": "^0.5.2",

packages/cli-repl/package.json

@@ -108,8 +108,11 @@ describe('CliRepl', () => {
       });
 
       it('verifies the Node.js version', async() => {
+        const origVersionCheckEnvVar = process.env.MONGOSH_SKIP_NODE_VERSION_CHECK;
+        delete process.env.MONGOSH_SKIP_NODE_VERSION_CHECK;
         delete (process as any).version;
         process.version = 'v8.0.0';
+
         try {
           cliRepl = new CliRepl(cliReplOptions);
           const onerror = once(cliRepl.bus, 'mongosh:error');
@@ -119,6 +122,7 @@ describe('CliRepl', () => {
           await onerror;
         } finally {
           process.version = process.versions.node;
+          process.env.MONGOSH_SKIP_NODE_VERSION_CHECK = origVersionCheckEnvVar || '';
         }
       });
     });

packages/cli-repl/src/cli-repl.spec.ts

@@ -142,6 +142,9 @@ class CliRepl {
   }
 
   verifyNodeVersion(): void {
+    if (process.env.MONGOSH_SKIP_NODE_VERSION_CHECK) {
+      return;
+    }
     const { engines } = require('../package.json');
     // Strip -rc.0, -pre, etc. from the Node.js version because semver rejects those otherwise.
     const baseNodeVersion = process.version.replace(/-.*$/, '');

packages/cli-repl/src/cli-repl.ts

@@ -34,6 +34,6 @@
     "access": "public"
   },
   "engines": {
-    "node": ">=12.4.0"
+    "node": ">=14.15.0"
   }
 }