refactor: allow only history()

Author: gagik

packages/cli-repl/src/mongosh-repl.spec.ts

@@ -572,22 +572,6 @@ describe('MongoshNodeRepl', function () {
                 )
               );
             });
-
-            it('works without ()', async function () {
-              output = '';
-              input.write('history\n');
-              await waitEval(bus);
-              expect(output).includes(
-                formatOutput(
-                  {
-                    value: getAllHistoryItems()
-                      .slice(1, getAllHistoryItems().length)
-                      .reverse(),
-                  },
-                  { colors: true, maxArrayLength: Infinity }
-                )
-              );
-            });
           });
 
           it('looks up existing entries, if there are any', async function () {

packages/cli-repl/src/mongosh-repl.ts

@@ -397,7 +397,7 @@ class MongoshNodeRepl implements EvaluationListener {
   }
 
   setupHistoryCommand(): void {
-    const getHistory = () => {
+    const history = () => {
       // eslint-disable-next-line @typescript-eslint/no-explicit-any
       const replHistory: string[] = (this.runtimeState().repl as any).history;
       const formattedHistory =
@@ -408,7 +408,7 @@ class MongoshNodeRepl implements EvaluationListener {
       formattedHistory[util.inspect.custom as any] = (() => {
         return formatOutput(
           {
-            // The value of the format has to be a copy of the history to avoid circular references.
+            // Providing a copy of the history avoids a circular reference.
             value: formattedHistory.concat(),
           },
           { colors: true, maxArrayLength: Infinity }
@@ -418,20 +418,7 @@ class MongoshNodeRepl implements EvaluationListener {
       return formattedHistory;
     };
 
-    getHistory.isDirectShellCommand = true;
-    getHistory.returnsPromise = false;
-    getHistory.acceptsRawInput = true;
-
-    this.runtimeState().context.history =
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (this.runtimeState().instanceState.shellApi as any).history = getHistory;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (signatures.ShellApi.attributes as any).history = {
-      type: 'function',
-      returnsPromise: true,
-      isDirectShellCommand: true,
-      acceptsRawInput: true,
-    } as TypeSignature;
+    this.runtimeState().context.history = history;
   }
 
   private async finishInitializingNodeRepl(): Promise<void> {