Add a test

Author: nirinchev

configs/eslint-config-mongosh/index.js

@@ -93,6 +93,7 @@ module.exports = {
         ...common.testRules,
         ...extraJSRules,
         ...extraTypescriptRules,
+        '@typescript-eslint/no-non-null-assertion': 'off',
       },
     },
   ],

packages/cli-repl/src/clr.ts

@@ -14,7 +14,7 @@ export type StyleDefinition =
 /** Optionally colorize a string, given a set of style definition(s). */
 export default function colorize(
   text: string,
-  style: StyleDefinition,
+  style: StyleDefinition | undefined,
   options: { colors: boolean }
 ): string {
   if (options.colors) {

packages/cli-repl/src/mongosh-repl.ts

@@ -116,7 +116,7 @@ type MongoshRuntimeState = {
 
 type GreetingDetails = {
   moreRecentMongoshVersion?: string | null;
-  currentVersionCTA?: { text: string; style: StyleDefinition }[];
+  currentVersionCTA?: { text: string; style?: StyleDefinition }[];
 };
 
 /* Utility, inverse of Readonly<T> */

packages/cli-repl/src/update-notification-manager.spec.ts

@@ -7,6 +7,7 @@ import type { AddressInfo } from 'net';
 import os from 'os';
 import path from 'path';
 import { UpdateNotificationManager } from './update-notification-manager';
+import type { MongoshVersionsContents } from './update-notification-manager';
 import sinon from 'sinon';
 
 describe('UpdateNotificationManager', function () {
@@ -122,4 +123,73 @@ describe('UpdateNotificationManager', function () {
       await manager.getLatestVersionIfMoreRecent('1.0.0-alpha.0')
     ).to.equal(null);
   });
+
+  it('figures out the greeting CTA when set on a global level', async function () {
+    const response: MongoshVersionsContents = {
+      versions: [
+        { version: '1.0.0' },
+        {
+          version: '1.1.0',
+          cta: { chunks: [{ text: "Don't use 1.1.0, downgrade!!" }] },
+        },
+      ],
+      cta: {
+        chunks: [{ text: 'Vote for your favorite feature!', style: 'bold' }],
+      },
+    };
+    reqHandler.callsFake((req, res) => {
+      res.end(JSON.stringify(response));
+    });
+
+    const manager = new UpdateNotificationManager();
+    await manager.fetchUpdateMetadata(httpServerUrl, filename, '1.0.0');
+
+    const cta = await manager.getGreetingCTAForCurrentVersion();
+    expect(cta).to.not.be.undefined;
+    expect(cta?.length).to.equal(1);
+    expect(cta![0]?.text).to.equal('Vote for your favorite feature!');
+    expect(cta![0]?.style).to.equal('bold');
+  });
+
+  it('figures out the greeting CTA when set on a per-version basis', async function () {
+    const response: MongoshVersionsContents = {
+      versions: [
+        {
+          version: '1.0.0',
+          cta: {
+            chunks: [
+              { text: "Don't use 1.0.0, upgrade!! " },
+              {
+                text: 'https://downloads.mongodb.com/mongosh/1.1.0/',
+                style: 'mongosh:uri',
+              },
+            ],
+          },
+        },
+        {
+          version: '1.1.0',
+          cta: { chunks: [{ text: 'This version is very safe!' }] },
+        },
+      ],
+      cta: {
+        chunks: [{ text: 'Vote for your favorite feature!', style: 'bold' }],
+      },
+    };
+    reqHandler.callsFake((req, res) => {
+      res.end(JSON.stringify(response));
+    });
+
+    const manager = new UpdateNotificationManager();
+    await manager.fetchUpdateMetadata(httpServerUrl, filename, '1.0.0');
+
+    const cta = await manager.getGreetingCTAForCurrentVersion();
+    expect(cta).to.not.be.undefined;
+    expect(cta?.length).to.equal(2);
+    expect(cta![0]?.text).to.equal("Don't use 1.0.0, upgrade!! ");
+    expect(cta![0]?.style).to.be.undefined;
+    expect(cta![1]?.text).to.equal(
+      'https://downloads.mongodb.com/mongosh/1.1.0/'
+    );
+    expect(cta![1]?.style).to.equal('mongosh:uri');
+  });
 });

packages/cli-repl/src/update-notification-manager.ts

@@ -7,16 +7,16 @@ import type {
   Response,
 } from '@mongodb-js/devtools-proxy-support';
 import { createFetch } from '@mongodb-js/devtools-proxy-support';
-import { StyleDefinition } from './clr';
+import type { StyleDefinition } from './clr';
 
 interface GreetingCTADetails {
   chunks: {
     text: string;
-    style: StyleDefinition;
+    style?: StyleDefinition;
   }[];
 }
 
-interface MongoshVersionsContents {
+export interface MongoshVersionsContents {
   versions: {
     version: string;
     cta?: GreetingCTADetails;
@@ -72,7 +72,7 @@ export class UpdateNotificationManager {
   async getGreetingCTAForCurrentVersion(): Promise<
     | {
         text: string;
-        style: StyleDefinition;
+        style?: StyleDefinition;
       }[]
     | undefined
   > {