fix(cli-repl): avoid instantiating libmongocrypt for mongosh --version (#1739)

Author: addaleax

packages/cli-repl/src/build-info.ts

@@ -33,20 +33,7 @@ function getSystemArch(): (typeof process)['arch'] {
     : process.arch;
 }
 
-/**
- * Return an object with information about this mongosh instance,
- * in particular, when it was built and how.
- */
-// eslint-disable-next-line @typescript-eslint/require-await
-export async function buildInfo({
-  withSegmentApiKey,
-}: {
-  withSegmentApiKey?: boolean;
-} = {}): Promise<BuildInfo> {
-  const dependencyVersionInfo: BuildInfo['deps'] = {
-    ...CliServiceProvider.getVersionInformation(),
-  };
-
+export function baseBuildInfo(): Omit<BuildInfo, 'deps'> {
   const runtimeData = {
     nodeVersion: process.version,
     opensslVersion: process.versions.openssl,
@@ -57,15 +44,13 @@ export async function buildInfo({
     // Runtime platform can differ e.g. because homebrew on macOS uses
     // npm packages published from Linux
     runtimePlatform: process.platform,
-    deps: { ...dependencyVersionInfo },
   };
 
   try {
-    const buildInfo = { ...require('./build-info.json'), ...runtimeData };
-    if (!withSegmentApiKey) {
-      delete buildInfo.segmentApiKey;
-    }
-    return buildInfo;
+    return {
+      ...require('./build-info.json'),
+      ...runtimeData,
+    };
   } catch {
     const { version } = require('../package.json');
     return {
@@ -80,3 +65,24 @@ export async function buildInfo({
     };
   }
 }
+
+/**
+ * Return an object with information about this mongosh instance,
+ * in particular, when it was built and how.
+ */
+// eslint-disable-next-line @typescript-eslint/require-await
+export async function buildInfo({
+  withSegmentApiKey,
+}: {
+  withSegmentApiKey?: boolean;
+} = {}): Promise<BuildInfo> {
+  const dependencyVersionInfo: BuildInfo['deps'] = {
+    ...CliServiceProvider.getVersionInformation(),
+  };
+
+  const buildInfo = { ...baseBuildInfo(), deps: { ...dependencyVersionInfo } };
+  if (!withSegmentApiKey) {
+    delete buildInfo.segmentApiKey;
+  }
+  return buildInfo;
+}

packages/cli-repl/src/run.ts

@@ -17,7 +17,7 @@ import { CliRepl } from './cli-repl';
 import { parseCliArgs } from './arg-parser';
 import { runSmokeTests } from './smoke-tests';
 import { USAGE } from './constants';
-import { buildInfo } from './build-info';
+import { baseBuildInfo, buildInfo } from './build-info';
 import { getStoragePaths, getGlobalConfigPaths } from './config-directory';
 import { getCryptLibraryPaths } from './crypt-library-paths';
 import { getTlsCertificateSelector } from './tls-certificate-selector';
@@ -116,7 +116,7 @@ async function main() {
     }
 
     if (options.version) {
-      console.log((await buildInfo()).version);
+      console.log(baseBuildInfo().version);
       return;
     }
     if (options.buildInfo) {