Run tests except karma on windows

Author: durran

.evergreen.yml

@@ -181,6 +181,7 @@ tasks:
   - name: release_win
     depends_on:
       - name: check
+      - name: test
     commands:
       - func: checkout
       - func: install
@@ -214,6 +215,7 @@ buildvariants:
     run_on: windows-64-vs2019-test
     tasks:
       - name: check
+      - name: test
       - name: release_win
   - name: windows_ps
     display_name: "Windows VS 2019 PowerShell"

config/build.conf.js

@@ -60,5 +60,6 @@ module.exports = {
   segmentKey: process.env.SEGMENT_API_KEY,
   appleUser: process.env.APPLE_DEV_USER,
   applePassword: process.env.APPLE_DEV_PASSWORD,
-  appleAppIdentity: process.env.APPLE_APP_IDENTITY
+  appleAppIdentity: process.env.APPLE_APP_IDENTITY,
+  isCi: process.env.IS_CI
 };

packages/browser-repl/package.json

@@ -14,7 +14,6 @@
     "start": "npm run storybook",
     "storybook": "start-storybook -p 6006",
     "test": "karma start ./config/karma.conf.js --colors",
-    "test-ci": "npm run lint && npm run test",
     "lint": "eslint \"**/*.{js,ts,tsx}\"",
     "check": "npm run lint",
     "compile-ts": "npm run build"

packages/build/src/macos-sign.ts

@@ -5,6 +5,15 @@ import { notarize as nodeNotarize } from 'electron-notarize';
 import Config from './config';
 import zip from './zip';
 
+/**
+ * Notarizes the zipped mongosh. Will send the zip to Apple and poll apple
+ * for the notarization result.
+ *
+ * @param {string} bundleId - The bundle id (com.mongodb.mongosh)
+ * @param {string} artifact - The path to the zip.
+ * @param {string} user - The apple dev account user.
+ * @param {string} password - The apple dev account password.
+ */
 const notarize = (bundleId: string, artifact: string, user: string, password: string) => {
   return nodeNotarize({
     appBundleId: bundleId,
@@ -14,6 +23,12 @@ const notarize = (bundleId: string, artifact: string, user: string, password: st
   });
 };
 
+/**
+ * Signs the executable via codesign.
+ *
+ * @param {string} executable - The mongosh executable.
+ * @param {string} identity - The apple developer identity.
+ */
 const sign = (executable: string, identity: string) => {
   return new Promise((resolve, reject) => {
     codesign({ identity: identity, appPath: executable }, (err, paths) => {

packages/cli-repl/bin/mongosh.js

@@ -1,7 +1,5 @@
 const { CliRepl, parseCliArgs, mapCliToDriver, generateUri, USAGE } = require('../lib');
 
-process.title = 'mongosh';
-
 try {
   const options = parseCliArgs(process.argv);
   const { version } = require('../package.json');
@@ -11,10 +9,10 @@ try {
   } else if (options.version) {
     console.log(version);
   } else {
+    process.title = 'mongosh';
     const driverOptions = mapCliToDriver(options);
     const driverUri = generateUri(options);
     const appname = `${process.title} ${version}`;
-
     new CliRepl(driverUri, { appname, ...driverOptions }, options);
   }
 } catch (e) {