Skip to content

Commit 2416a35

Browse files
authored
fix(config): map build variants correctly (#455)
In particular, map `darwin_codesign` to `darwin` because that influences the path where the release artifact ends up being put.
1 parent 08d5a72 commit 2416a35

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

config/build.conf.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,8 @@ const REVISION = process.env.IS_PATCH ?
5050
`pr-${process.env.GITHUB_PR_NUMBER}-${process.env.REVISION_ORDER_ID}` :
5151
process.env.REVISION;
5252

53+
const BUILD_VARIANT = (process.env.BUILD_VARIANT || '').split('_')[0];
54+
5355
/**
5456
* Export the configuration for the build.
5557
*/
@@ -73,7 +75,7 @@ module.exports = {
7375
isPatch: process.env.IS_PATCH === 'true',
7476
platform: os.platform(),
7577
execNodeVersion: process.env.NODE_JS_VERSION || `^${process.version.slice(1)}`,
76-
buildVariant: process.env.BUILD_VARIANT,
78+
buildVariant: BUILD_VARIANT,
7779
appleCodesignIdentity: process.env.APPLE_CODESIGN_IDENTITY,
7880
appleCodesignEntitlementsFile: path.resolve(__dirname, 'macos-entitlements.xml'),
7981
appleNotarizationBundleId: APPLE_NOTARIZATION_BUNDLE_ID,

0 commit comments

Comments
 (0)