fix: use prefix even if custom location is same as home location

Author: gagik

packages/cli-repl/src/cli-repl.spec.ts

@@ -1448,7 +1448,10 @@ describe('CliRepl', function () {
             );
           });
 
-          it('does not use a prefix if the custom location is the same as the home location', async function () {
+          it('uses a prefix even if the custom location is the same as the home location', async function () {
+            // This is a corner case where the custom location is the same as the home location.
+            // The prefix is still added to the log file name for consistency. If the user needs
+            // the default behavior for the log names, they should instead set the location to undefined.
             const customLogHomePath = cliRepl.shellHomeDirectory.localPath('.');
             cliRepl.config.logLocation = customLogHomePath;
             await cliRepl.start(await testServer.connectionString(), {});

packages/cli-repl/src/cli-repl.ts

@@ -255,12 +255,11 @@ export class CliRepl implements MongoshIOProvider {
       throw new Error('Logging and telemetry not setup');
     }
 
-    const defaultDirectory = this.shellHomeDirectory.localPath('.');
-    const directory = (await this.getConfig('logLocation')) || defaultDirectory;
+    const customLogLocation = await this.getConfig('logLocation');
 
     this.logManager ??= new MongoLogManager({
-      directory,
-      prefix: directory !== defaultDirectory ? 'mongosh_' : undefined,
+      directory: customLogLocation || this.shellHomeDirectory.localPath('.'),
+      prefix: customLogLocation ? 'mongosh_' : undefined,
       retentionDays: await this.getConfig('logRetentionDays'),
       gzip: await this.getConfig('logCompressionEnabled'),
       maxLogFileCount: await this.getConfig('logMaxFileCount'),