fix: fix download center json and add tests (#324)

Author: mcasimir

packages/build/package-lock.json

@@ -30,6 +30,7 @@
     ]
   },
   "devDependencies": {
+    "ajv": "^6.12.5",
     "nock": "^13.0.4",
     "sinon-chai": "^3.5.0"
   },

packages/build/package.json

@@ -0,0 +1,84 @@
+const downloadCenterSchema = {
+  'type': 'object',
+  'required': [
+    'versions',
+    'manual_link',
+    'release_notes_link',
+    'previous_releases_link',
+    'development_releases_link',
+    'supported_browsers_link',
+    'tutorial_link'
+  ],
+  'properties': {
+    'versions': {
+      'type': 'array',
+      'additionalItems': false,
+      'items': {
+        'type': 'object',
+        'required': [
+          '_id',
+          'version',
+          'platform'
+        ],
+        'properties': {
+          '_id': {
+            'type': 'string'
+          },
+          'version': {
+            'type': 'string'
+          },
+          'platform': {
+            'type': 'array',
+            'additionalItems': false,
+            'items': {
+              'type': 'object',
+              'required': [
+                'arch',
+                'os',
+                'name',
+                'download_link'
+              ],
+              'properties': {
+                'arch': {
+                  'type': 'string'
+                },
+                'os': {
+                  'type': 'string'
+                },
+                'name': {
+                  'type': 'string'
+                },
+                'download_link': {
+                  'type': 'string'
+                }
+              },
+              'additionalProperties': false
+            }
+          }
+        },
+        'additionalProperties': false
+      }
+    },
+    'manual_link': {
+      'type': 'string'
+    },
+    'release_notes_link': {
+      'type': 'string'
+    },
+    'previous_releases_link': {
+      'type': 'string'
+    },
+    'development_releases_link': {
+      'type': 'string'
+    },
+    'supported_browsers_link': {
+      'type': 'string'
+    },
+    'tutorial_link': {
+      'type': 'string'
+    }
+  },
+  'additionalProperties': false
+};
+
+export default downloadCenterSchema;

packages/build/src/download-center-schema.ts

@@ -1,11 +1,24 @@
 import { expect } from 'chai';
 import nock from 'nock';
 
+import Ajv from 'ajv';
+
+import downloadCenterSchema from './download-center-schema';
+
 import {
   createDownloadCenterConfig,
   verifyDownloadCenterConfig
 } from './download-center';
 
+function validateWithSchema(obj, schema): void {
+  const ajv = new Ajv();
+  const validate = ajv.compile(schema);
+  const valid = validate(obj);
+  if (!valid) {
+    throw new Error(ajv.errorsText(validate.errors));
+  }
+}
+
 describe('download center module', () => {
   describe('.createDownloadCenterConfig', () => {
     let config;
@@ -25,6 +38,14 @@ describe('download center module', () => {
     it('returns the string with the win version injected', () => {
       expect(config).to.include('mongosh-1.2.2-win32.zip');
     });
+
+    it('produces a well formed json', () => {
+      expect(() => { JSON.parse(config); }).not.to.throw();
+    });
+
+    it('produces a json valid for the download center', () => {
+      validateWithSchema(JSON.parse(config), downloadCenterSchema);
+    });
   });
 
   describe('.verifyDownloadCenterConfig', () => {

packages/build/src/download-center.spec.ts

@@ -71,7 +71,7 @@ const CONFIG = `
           "os": "debian",
           "name": "Debian 64-bit",
           "download_link": "https://downloads.mongodb.com/compass/mongosh_{{version}}_amd64.deb"
-        }
+        },
         {
           "arch": "x64",
           "os": "rhel",