Skip to content

Commit 2e13801

Browse files
committed
CR comments
1 parent b1fb4f8 commit 2e13801

File tree

2 files changed

+8
-2
lines changed

2 files changed

+8
-2
lines changed

.github/workflows/update-cta.yml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,9 @@ on:
1818
required: true
1919
default: CTA-Production
2020

21+
permissions:
22+
contents: read
23+
2124
jobs:
2225
dry-run:
2326
name: Update greeting CTA

packages/build/src/config/config.ts

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,11 +8,14 @@ interface ManPageConfig {
88
fileName: string;
99
}
1010

11-
// TODO: this is duplicated in update-notification-manager.ts
11+
// This needs to match the interface in cli-repl/update-notification-manager.ts
1212
export interface GreetingCTADetails {
1313
chunks: {
1414
text: string;
15-
style?: string; // TODO: this is actually clr.ts/StyleDefinition
15+
// This is actually cli-repl/clr.ts/StyleDefinition, but we can't import it here.
16+
// The correct type is already enforced in json schema, so treating it as a generic
17+
// string is fine.
18+
style?: string;
1619
}[];
1720
}
1821

0 commit comments

Comments
 (0)