Proper raw uploading to Github

Author: durran

packages/build/src/github.ts

@@ -1,7 +1,9 @@
 import fs from 'fs';
+import { StringDecoder } from 'string_decoder';
 import path from 'path';
 import { Octokit } from '@octokit/rest';
 import semver from 'semver';
+import Platform from './platform';
 
 /**
  * The repo we are working on.
@@ -16,16 +18,17 @@ const REPO = Object.freeze({
  *
  * @param {string} version - The current version.
  * @param {string} artifact - The artifact path.
+ * @param {string} platform - The platform.
  * @param {Octokit} octokit - The octokit instance.
  */
-const releaseToGithub = async(version: string, artifact: string, octokit: Octokit): Promise<any> => {
+const releaseToGithub = async(version: string, artifact: string, platform: string, octokit: Octokit): Promise<any> => {
   const latestRelease = await getLatestRelease(octokit);
   if (semver.gt(version, latestRelease.tag_name.replace('v', ''))) {
     // Create a new release if our version is higher than latest.
     const newRelease = await createRelease(version, octokit);
-    await uploadAsset(artifact, newRelease.id, octokit);
+    await uploadAsset(artifact, platform, newRelease.upload_url, octokit);
   } else {
-    await uploadAsset(artifact, latestRelease.id, octokit);
+    await uploadAsset(artifact, platform, latestRelease.upload_url, octokit);
   }
 };
 
@@ -67,18 +70,22 @@ const createRelease = async(version: string, octokit: Octokit): Promise<any> =>
  * Upload the asset to the release.
  *
  * @param {string} artifact - The artifact.
- * @param {number} releaseId - The release id.
+ * @param {string} platform - The platform.
+ * @param {string} uploadUrl - The release endpoint.
  * @param {Octokit} octokit - The octokit instance.
  */
-const uploadAsset = (artifact: string, releaseId: number, octokit: Octokit): Promise<any> => {
+const uploadAsset = (artifact: string, platform: string, uploadUrl: string, octokit: Octokit): Promise<any> => {
   const params = {
-    ...REPO,
-    release_id: releaseId,
+    method: 'POST',
+    url: uploadUrl,
+    headers: {
+      'content-type': platform === Platform.Linux ? 'application/gzip' : 'application/zip'
+    },
     name: path.basename(artifact),
-    data: artifact
+    data: fs.readFileSync(artifact)
   };
-  console.log('mongosh: uploading asset:', artifact);
-  return octokit.repos.uploadReleaseAsset(params).catch((e) => {
+  console.log('mongosh: uploading asset to github:', artifact);
+  return octokit.request(params).catch((e) => {
     // If the asset already exists it will throw, but we just log
     // it since we don't want to overwrite assets.
     console.error(e);

packages/build/src/release.ts

@@ -49,7 +49,7 @@ const release = async(config: Config) => {
   );
 
   // - Create release and upload assets to Github.
-  await releaseToGithub(config.version, artifact, octokit);
+  await releaseToGithub(config.version, artifact, platform, octokit);
 
   // - Publish the .deb (only on linux)
   // - Publish the .rpm (only on linux)