Skip to content

Commit 2e9d7b8

Browse files
committed
fix a semver check in old autocomplete
1 parent 43f93c3 commit 2e9d7b8

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

packages/autocomplete/src/index.ts

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -290,6 +290,12 @@ export async function completer(
290290
return [[], line];
291291
}
292292

293+
// from https://github.com/mongodb-js/devtools-shared/commit/e4a5b00a83b19a76bdf380799a421511230168db
294+
function satisfiesVersion(v1: string, v2: string): boolean {
295+
const isGTECheck = /^\d+?\.\d+?\.\d+?$/.test(v2);
296+
return semver.satisfies(v1, isGTECheck ? `>=${v2}` : v2);
297+
}
298+
293299
function isAcceptable(
294300
params: AutocompleteParameters,
295301
entry: {
@@ -310,7 +316,10 @@ function isAcceptable(
310316
!entry[versionKey] ||
311317
// TODO: when https://jira.mongodb.org/browse/SPM-2327 is done we can rely on server_version being present
312318
!connectionInfo?.server_version ||
313-
semver.gte(connectionInfo.server_version, entry[versionKey] as string);
319+
satisfiesVersion(
320+
connectionInfo.server_version,
321+
entry[versionKey] as string
322+
);
314323
}
315324
const isAcceptableEnvironment =
316325
!entry.env ||

0 commit comments

Comments
 (0)