chore(deps): bump driver to 4.2.1 COMPASS-5340 (#1168)

* chore(deps): bump driver to 4.2.1 COMPASS-5340

Bump the Node.js driver to 4.2.1 and its bson package to 4.6.0.

* fixup: adjust types to account for webpack TS problem

Author: addaleax

package-lock.json

@@ -122,7 +122,7 @@
     "karma-typescript": "^5.5.1",
     "lerna": "^4.0.0",
     "mocha": "^7.1.2",
-    "mongodb": "^4.1.4",
+    "mongodb": "^4.2.1",
     "mongodb-download-url": "^1.1.2",
     "mongodb-js-precommit": "^2.0.0",
     "nock": "^13.0.11",

package.json

@@ -33,7 +33,7 @@
     "@mongosh/service-provider-core": "0.0.0-dev.0",
     "@mongosh/service-provider-server": "0.0.0-dev.0",
     "@mongosh/types": "0.0.0-dev.0",
-    "bson": "^4.5.4",
+    "bson": "^4.6.0",
     "mocha": "^7.1.2",
     "postmsg-rpc": "^2.4.0",
     "terser-webpack-plugin": "^4.2.3",

packages/node-runtime-worker-thread/package-lock.json

@@ -85,13 +85,21 @@ const workerRuntime: WorkerRuntime = {
     driverOptions: MongoClientOptions = {},
     cliOptions: { nodb?: boolean } = {}
   ) {
-    provider = await CompassServiceProvider.connect(
+    // XXX The types here work out fine, and tsc accepts this code
+    // without 'as any'. However, since a change to the driver's
+    // .find() method signature (https://github.com/mongodb/node-mongodb-native/commit/307d623ea597c5d89c548b6731bd692fec7a8047)
+    // the webpack integration build fails with:
+    // [tsl] ERROR in /home/addaleax/src/mongosh/packages/node-runtime-worker-thread/src/worker-runtime.ts(88,5)
+    //       TS2589: Type instantiation is excessively deep and possibly infinite.
+    // I could not figure out why exactly that was the case, so 'as any'
+    // will have to do for now.
+    provider = await (CompassServiceProvider as any).connect(
       uri,
       driverOptions,
       cliOptions,
       messageBus
     );
-    runtime = new ElectronRuntime(provider, messageBus);
+    runtime = new ElectronRuntime(provider as ServiceProvider, messageBus);
     runtime.setEvaluationListener(evaluationListener);
   },
 

packages/node-runtime-worker-thread/package.json

@@ -32,8 +32,8 @@
   "dependencies": {
     "@mongosh/errors": "0.0.0-dev.0",
     "@mongosh/i18n": "0.0.0-dev.0",
-    "bson": "^4.5.4",
-    "mongodb": "^4.1.4",
+    "bson": "^4.6.0",
+    "mongodb": "^4.2.1",
     "mongodb-build-info": "^1.2.0",
     "mongodb-connection-string-url": "^2.2.0"
   },

packages/node-runtime-worker-thread/src/worker-runtime.ts

@@ -43,7 +43,7 @@
     "@mongosh/types": "0.0.0-dev.0",
     "@types/sinon-chai": "^3.2.3",
     "aws4": "^1.11.0",
-    "mongodb": "^4.1.4",
+    "mongodb": "^4.2.1",
     "mongodb-connection-string-url": "^2.2.0",
     "saslprep": "mongodb-js/saslprep#v1.0.4"
   },

packages/service-provider-core/package-lock.json

@@ -56,7 +56,7 @@ export default class ChangeStreamCursor extends ShellApiWithMongoClass {
 
   @returnsPromise
   @deprecated
-  async hasNext(): Promise<void> {
+  async hasNext(): Promise<boolean> {
     await this._instanceState.printWarning(
       'If there are no documents in the batch, hasNext will block. Use tryNext if you want to check if there ' +
       'are any documents without waiting.'