chore(typescript): enable erasableSyntaxOnly for the whole repo (#2601)

Inspired by mongodb-js/compass#7613

Author: addaleax

configs/tsconfig-mongosh/tsconfig.common.json

@@ -9,6 +9,7 @@
     "noUnusedLocals": false,
     "noUnusedParameters": false,
     "noImplicitReturns": true,
+    "erasableSyntaxOnly": true,
 
     "declaration": true,
     "removeComments": true,

packages/async-rewriter2/src/error-codes.ts

@@ -3,7 +3,7 @@
 /**
  * @mongoshErrors
  */
-enum AsyncRewriterErrors {
+export const AsyncRewriterErrors = {
   /**
    * Signals the use of a Mongosh API call in a place where it is not supported.
    * This occurs inside of constructors and (non-async) generator functions.
@@ -23,7 +23,7 @@ enum AsyncRewriterErrors {
    *
    * **Solution: Do not use calls directly in such functions. If necessary, place these calls in an inner 'async' function.**
    */
-  SyntheticPromiseInAlwaysSyncContext = 'ASYNC-10012',
+  SyntheticPromiseInAlwaysSyncContext: 'ASYNC-10012',
   /**
    * Signals the iteration of a Mongosh API object in a place where it is not supported.
    * This occurs inside of constructors and (non-async) generator functions.
@@ -44,7 +44,5 @@ enum AsyncRewriterErrors {
    *
    * **Solution: Do not use calls directly in such functions. If necessary, place these calls in an inner 'async' function.**
    */
-  SyntheticAsyncIterableInAlwaysSyncContext = 'ASYNC-10013',
-}
-
-export { AsyncRewriterErrors };
+  SyntheticAsyncIterableInAlwaysSyncContext: 'ASYNC-10013',
+} as const;

packages/autocomplete/src/index.spec.ts

@@ -1,12 +1,12 @@
 import { completer, BASE_COMPLETIONS } from './';
-import { signatures as shellSignatures, Topologies } from '@mongosh/shell-api';
+import { signatures as shellSignatures } from '@mongosh/shell-api';
 
 import { expect } from 'chai';
 
 let collections: string[];
 let databases: string[];
 const standalone600 = {
-  topology: () => Topologies.Standalone,
+  topology: () => 'Standalone' as const,
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({
     is_atlas: false,
@@ -18,7 +18,7 @@ const standalone600 = {
   getDatabaseCompletions: () => databases,
 };
 const standalone440 = {
-  topology: () => Topologies.Standalone,
+  topology: () => 'Standalone' as const,
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({
     is_atlas: false,
@@ -30,7 +30,7 @@ const standalone440 = {
   getDatabaseCompletions: () => databases,
 };
 const apiStrictParams = {
-  topology: () => Topologies.Standalone,
+  topology: () => 'Standalone' as const,
   apiVersionInfo: () => ({
     version: '1',
     strict: true,
@@ -41,7 +41,7 @@ const apiStrictParams = {
   getDatabaseCompletions: () => databases,
 };
 const sharded440 = {
-  topology: () => Topologies.Sharded,
+  topology: () => 'Sharded' as const,
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({
     is_atlas: false,
@@ -54,7 +54,7 @@ const sharded440 = {
 };
 
 const standalone300 = {
-  topology: () => Topologies.Standalone,
+  topology: () => 'Standalone' as const,
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({
     is_atlas: false,
@@ -66,7 +66,7 @@ const standalone300 = {
   getDatabaseCompletions: () => databases,
 };
 const datalake440 = {
-  topology: () => Topologies.Sharded,
+  topology: () => 'Sharded' as const,
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({
     is_atlas: true,
@@ -79,7 +79,7 @@ const datalake440 = {
 };
 
 const localAtlas600 = {
-  topology: () => Topologies.Standalone,
+  topology: () => 'Standalone' as const,
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({
     is_atlas: false,
@@ -100,7 +100,7 @@ const noParams = {
 };
 
 const emptyConnectionInfoParams = {
-  topology: () => Topologies.Standalone,
+  topology: () => 'Standalone' as const,
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({}),
   getCollectionCompletionsForCurrentDb: () => collections,

packages/browser-runtime-core/src/autocompleter/shell-api-autocompleter.spec.ts

@@ -1,11 +1,10 @@
 import { ShellApiAutocompleter } from './shell-api-autocompleter';
 import { expect } from 'chai';
-import { Topologies } from '@mongosh/shell-api';
 import type { AutocompleteParameters } from '@mongosh/autocomplete';
 import type { AutocompletionContext } from '@mongodb-js/mongodb-ts-autocomplete';
 
 const standalone440Parameters: AutocompleteParameters = {
-  topology: () => Topologies.Standalone,
+  topology: () => 'Standalone',
   apiVersionInfo: () => undefined,
   connectionInfo: () => ({
     is_atlas: false,

packages/build/src/barque.spec.ts

@@ -333,7 +333,7 @@ describe('Barque', function () {
     });
 
     it('platform is not linux', function () {
-      config.platform = 'macos';
+      config.platform = 'darwin';
       try {
         barque = new Barque(config);
       } catch (e: any) {

packages/build/src/barque.ts

@@ -11,13 +11,7 @@ import tmp from 'tmp-promise';
 import util, { promisify } from 'util';
 import type { PackageVariant, Config } from './config';
 import semver from 'semver';
-import {
-  getArch,
-  getDistro,
-  getDebArchName,
-  getRPMArchName,
-  Platform,
-} from './config';
+import { getArch, getDistro, getDebArchName, getRPMArchName } from './config';
 import { withRetries } from './helpers';
 import type {
   PPARepository,
@@ -120,7 +114,7 @@ export class Barque {
   private downloadedCuratorPromise: Promise<string> | undefined;
 
   constructor(config: Config) {
-    if (config.platform !== Platform.Linux) {
+    if (config.platform !== 'linux') {
       throw new Error('Barque publishing is only supported on linux platforms');
     }
 

packages/build/src/config/config.ts

@@ -50,7 +50,7 @@ export interface Config {
   notarySigningKeyName?: string;
   notaryAuthToken?: string;
   isCi?: boolean;
-  platform?: string;
+  platform?: NodeJS.Platform;
   execNodeVersion: string;
   packageVariant?: PackageVariant;
   repo: {

packages/build/src/config/platform.ts

@@ -4,8 +4,4 @@
  * Different from 'BuildVariant': platform is extracted from os.platform() and
  * build variant is the host evergreen is building on.
  */
-export enum Platform {
-  Windows = 'win32',
-  MacOs = 'darwin',
-  Linux = 'linux',
-}
+export type Platform = 'win32' | 'darwin' | 'linux';

packages/build/src/evergreen/rest-api.ts

@@ -22,12 +22,21 @@ export interface EvergreenTask {
 }
 
 export class EvergreenApi {
+  public readonly apiBasepath: string;
+  public readonly apiUser: string;
+  public readonly apiKey: string;
+  private readonly fetch: typeof fetchFn;
   constructor(
-    public readonly apiBasepath: string,
-    public readonly apiUser: string,
-    public readonly apiKey: string,
-    private readonly fetch: typeof fetchFn = fetchFn
-  ) {}
+    apiBasepath: string,
+    apiUser: string,
+    apiKey: string,
+    fetch: typeof fetchFn = fetchFn
+  ) {
+    this.apiBasepath = apiBasepath;
+    this.apiUser = apiUser;
+    this.apiKey = apiKey;
+    this.fetch = fetch;
+  }
 
   public static async fromUserConfiguration(
     pathToConfiguration = path.join(os.homedir(), '.evergreen.yml')

packages/build/src/homebrew/publish-to-homebrew.ts

@@ -12,18 +12,20 @@ export type HomebrewPublisherConfig = {
 };
 
 export class HomebrewPublisher {
+  public config: HomebrewPublisherConfig;
   readonly npmPackageSha256: typeof npmPackageSha256Fn;
   readonly generateFormula: typeof generateUpdatedFormulaFn;
   readonly updateHomebrewFork: typeof updateHomebrewForkFn;
 
   constructor(
-    public config: HomebrewPublisherConfig,
+    config: HomebrewPublisherConfig,
     {
       npmPackageSha256 = npmPackageSha256Fn,
       generateFormula = generateUpdatedFormulaFn,
       updateHomebrewFork = updateHomebrewForkFn,
     } = {}
   ) {
+    this.config = config;
     this.npmPackageSha256 = npmPackageSha256;
     this.generateFormula = generateFormula;
     this.updateHomebrewFork = updateHomebrewFork;