fix(cli-repl): show telemetry info only once MONGOSH-582 (#657)

Author: addaleax

packages/cli-repl/src/cli-repl.ts

@@ -201,7 +201,6 @@ class CliRepl {
   async setConfig<K extends keyof UserConfig>(key: K, value: UserConfig[K]): Promise<void> {
     this.config[key] = value;
     if (key === 'enableTelemetry') {
-      this.config.disableGreetingMessage = true;
       this.bus.emit('mongosh:update-user', this.config.userId, this.config.enableTelemetry);
     }
     try {

packages/cli-repl/src/mongosh-repl.spec.ts

@@ -94,6 +94,7 @@ describe('MongoshNodeRepl', () => {
       expect(output).to.match(/Using MongoDB:\s+4.4.1/);
       expect(output).to.match(/Using Mongosh Beta:/);
       expect(output).to.match(/You can opt-out by running the .*disableTelemetry\(\).* command/);
+      expect(config.disableGreetingMessage).to.equal(true);
     });
 
     it('evaluates javascript', async() => {

packages/cli-repl/src/mongosh-repl.ts

@@ -240,6 +240,7 @@ class MongoshNodeRepl implements EvaluationListener {
     text += `${MONGOSH_WIKI}\n`;
     if (!await this.configProvider.getConfig('disableGreetingMessage')) {
       text += `${TELEMETRY_GREETING_MESSAGE}\n`;
+      await this.configProvider.setConfig('disableGreetingMessage', true);
     }
     this.output.write(text);
   }

packages/cli-repl/test/e2e.spec.ts

@@ -550,7 +550,7 @@ describe('e2e', function() {
           const config = await readConfig();
           expect(config.userId).to.match(/^[a-f0-9]{24}$/);
           expect(config.enableTelemetry).to.be.true;
-          expect(config.disableGreetingMessage).to.be.false;
+          expect(config.disableGreetingMessage).to.be.true;
         });
 
         it('persists between sessions', async() => {