add basic bump tests, update evergreen config, and review fixes

Author: gagik

.evergreen.yml

@@ -4274,6 +4274,8 @@ functions:
           source .evergreen/setup-env.sh
           export PUPPETEER_SKIP_DOWNLOAD="true"
           npm run evergreen-release draft
+          git add .
+          git commit --no-allow-empty -m "chore(release): bump to prepare for mongosh release" 
           }
 
   release_publish_download_and_list_artifacts:

.github/workflows/bump-auxiliary-packages.yml

@@ -37,12 +37,10 @@ jobs:
           npm ci
 
       - name: Bump packages
-        env:
-          LAST_BUMP_COMMIT_MESSAGE: "chore(release): bump auxiliary packages"
         run: |
           npm run bump-auxiliary
           git add .
-          git commit --no-allow-empty -m "$LAST_BUMP_COMMIT_MESSAGE" || true
+          git commit --no-allow-empty -m "chore(release): bump auxiliary packages" || true
 
       - name: Create Pull Request
         uses: peter-evans/create-pull-request@5e914681df9dc83aa4e4905692ca88beb2f9e91f # 7.0.5

.github/workflows/publish-auxiliary-packages.yml

@@ -13,7 +13,7 @@ jobs:
   publish:
     if: |
       github.event_name == 'workflow_dispatch' ||
-        startsWith(github.event.head_commit.message, 'chore(release): bump auxiliary package versions')
+        startsWith(github.event.head_commit.message, 'chore(release): bump auxiliary packages')
 
     runs-on: ubuntu-latest
 

packages/build/src/npm-packages/bump.spec.ts

@@ -0,0 +1,69 @@
+import { expect } from 'chai';
+import type { SinonStub } from 'sinon';
+import sinon from 'sinon';
+import {
+  bumpMongoshReleasePackages,
+  updateShellApiMongoshVersion,
+} from './bump';
+import { promises as fs } from 'fs';
+import path from 'path';
+import { PROJECT_ROOT } from './constants';
+import * as monorepoTools from '@mongodb-js/monorepo-tools';
+
+describe('npm-packages bump', function () {
+  let fsReadFile: SinonStub;
+  let fsWriteFile: SinonStub;
+
+  beforeEach(function () {
+    fsReadFile = sinon.stub(fs, 'readFile');
+
+    fsWriteFile = sinon.stub(fs, 'writeFile');
+    fsWriteFile.resolves();
+  });
+
+  afterEach(function () {
+    sinon.restore();
+  });
+
+  describe('bumpMongoshReleasePackages', function () {
+    it('throws if MONGOSH_RELEASE_VERSION is not set', async function () {
+      process.env.MONGOSH_RELEASE_VERSION = '';
+
+      try {
+        await bumpMongoshReleasePackages();
+        expect.fail('did not error');
+      } catch (error) {
+        expect(error).instanceOf(Error);
+        expect((error as Error).message).equals(
+          'MONGOSH_RELEASE_VERSION version not specified during mongosh bump'
+        );
+      }
+    });
+  });
+
+  describe('updateShellApiMongoshVersion', function () {
+    it('updates the file to the set version', async function () {
+      fsReadFile.resolves(`
+    /** Current mongosh cli-repl version. */
+    export const MONGOSH_VERSION = '2.3.8';`);
+
+      const newVersion = '3.0.0';
+      await updateShellApiMongoshVersion(newVersion);
+
+      expect(fsWriteFile).calledWith(
+        path.join(
+          __dirname,
+          PROJECT_ROOT,
+          'packages',
+          'shell-api',
+          'src',
+          'mongosh-version.ts'
+        ),
+        `
+    /** Current mongosh cli-repl version. */
+    export const MONGOSH_VERSION = '${newVersion}';`,
+        'utf-8'
+      );
+    });
+  });
+});

packages/build/src/npm-packages/bump.ts

@@ -56,11 +56,11 @@ export async function bumpMongoshReleasePackages(): Promise<void> {
     );
   }
 
-  await bumpShellApiMongoshVersion(version);
+  await updateShellApiMongoshVersion(version);
 }
 
-/** Sets the shell-api constant to match the mongosh version. */
-export async function bumpShellApiMongoshVersion(version: string) {
+/** Updates the shell-api constant to match the mongosh version. */
+export async function updateShellApiMongoshVersion(version: string) {
   const shellApiVersionFilePath = path.join(
     __dirname,
     PROJECT_ROOT,