Skip to content

Commit 54e8224

Browse files
authored
Revert "chore(build): skip attempted PGP signing for now (#1174)" (#1181)
This reverts commit 01997ab.
1 parent c82b3a6 commit 54e8224

File tree

2 files changed

+4
-10
lines changed

2 files changed

+4
-10
lines changed

packages/build/src/run-draft.spec.ts

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -68,17 +68,15 @@ describe('draft', () => {
6868
});
6969

7070
it('asks the notary service to sign files', () => {
71-
// expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
71+
expect(notarizeArtifact).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
7272
});
7373

7474
it('uploads artifacts to download center', () => {
75-
expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
76-
// expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
75+
expect(uploadArtifactToDownloadCenter).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
7776
});
7877

7978
it('uploads the artifacts to the github release', () => {
80-
expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length);
81-
// expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
79+
expect(uploadReleaseAsset).to.have.been.callCount(ALL_BUILD_VARIANTS.length * 2);
8280
});
8381
});
8482

packages/build/src/run-draft.ts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,6 @@ export async function runDraft(
4444
tmpDir
4545
);
4646

47-
/*
48-
// pending https://jira.mongodb.org/browse/BUILD-14385
4947
await notarizeArtifact(
5048
tarballFile.path,
5149
{
@@ -55,12 +53,10 @@ export async function runDraft(
5553
}
5654
);
5755
const signatureFile = tarballFile.path + '.sig';
58-
*/
59-
void notarizeArtifact;
6056

6157
await Promise.all([
6258
[ downloadedArtifact, tarballFile.contentType ],
63-
// [ signatureFile, 'application/pgp-signature' ]
59+
[ signatureFile, 'application/pgp-signature' ]
6460
].flatMap(([ path, contentType ]) => [
6561
uploadToDownloadCenter(
6662
path,

0 commit comments

Comments
 (0)