chore: turn some javascript and typescript lint rules back into errors MONGOSH-1508 (#1631)

* bring back no-undef

* remove rule that only required one override

* bring back no-useless-escape

* add comment

* re-enable no-prototype-builtins

* re-enable @typescript-eslint/consistent-type-imports

* re-enable @typescript-eslint/no-unused-vars

* re-enable @typescript-eslint/prefer-regexp-exec

* ticket the remaining eslint warnings that should be errors

* rather just disable no-useless-escape

* remove async promise executor

* reject rather

* not a false positive

* fix new lint errors after merge

Author: lerouxb

configs/eslint-config-mongosh/index.js

@@ -3,8 +3,7 @@
 const shared = require('@mongodb-js/eslint-config-devtools');
 const common = require('@mongodb-js/eslint-config-devtools/common');
 
-// TODO(MONGOSH-1508) we need to turn these back into errors (and fix them) or ticket them
-const tempRules = {
+const extraJSRules = {
   'jsx-a11y/no-autofocus': 1,
   'jsx-a11y/click-events-have-key-events': 1,
   'jsx-a11y/no-static-element-interactions': 1,
@@ -14,28 +13,30 @@ const tempRules = {
   'mocha/max-top-level-suites': 1,
   'mocha/no-sibling-hooks': 1,
 
+  // this would disallow our locale files' filenames like de_DE.ts
   'filename-rules/match': 1,
 
-  'no-useless-escape': 1,
-  'no-undef': 1,
-  'no-prototype-builtins': 1,
-  'no-async-promise-executor': 1,
+  // TODO(MONGOSH-1580): re-enable this rule
   'no-case-declarations': 1,
 };
 
-// TODO(MONGOSH-1508) we need to turn these back into errors (and fix them) or ticket them
-const tempTypescriptRules = {
+const extraTypescriptRules = {
+  // this rule causes many false positives, so we leave it to just warn
   '@typescript-eslint/no-unnecessary-type-assertion': 1,
+
+  // TODO(MONGOSH-1581): re-enable this rule
   '@typescript-eslint/restrict-plus-operands': 1,
+  // TODO(MONGOSH-1582): re-enable this rule
   '@typescript-eslint/no-var-requires': 1,
+  // TODO(MONGOSH-1583): re-enable this rule
   '@typescript-eslint/restrict-template-expressions': 1,
+  // TODO(MONGOSH-1584): re-enable this rule
   '@typescript-eslint/no-empty-function': 1,
+  // TODO(MONGOSH-1585): re-enable this rule
   '@typescript-eslint/no-misused-promises': 1,
-  '@typescript-eslint/consistent-type-imports': 1,
+  // TODO(MONGOSH-1586): re-enable this rule
   '@typescript-eslint/unbound-method': 1,
-  '@typescript-eslint/no-implied-eval': 1,
-  '@typescript-eslint/no-unused-vars': 1,
-  '@typescript-eslint/prefer-regexp-exec': 1,
+  // TODO(MONGOSH-1587): re-enable this rule
   '@typescript-eslint/ban-types': 1,
 };
 
@@ -52,46 +53,46 @@ module.exports = {
       ...common.jsOverrides,
       rules: {
         ...common.jsRules,
-        ...tempRules,
+        ...extraJSRules,
       },
     },
     {
       ...common.jsxOverrides,
       rules: {
         ...common.jsxRules,
-        ...tempRules,
+        ...extraJSRules,
       },
     },
     {
       ...common.tsOverrides,
       rules: {
         ...common.tsRules,
-        ...tempRules,
-        ...tempTypescriptRules,
+        ...extraJSRules,
+        ...extraTypescriptRules,
       },
     },
     {
       ...common.tsxOverrides,
       rules: {
         ...common.tsxRules,
-        ...tempRules,
-        ...tempTypescriptRules,
+        ...extraJSRules,
+        ...extraTypescriptRules,
       },
     },
     {
       ...common.testOverrides,
       rules: {
         ...common.testRules,
-        ...tempRules,
+        ...extraJSRules,
       },
     },
     {
       ...common.testOverrides,
       files: ['**/*.spec.ts', '**/*.spec.tsx', '**/*.test.tsx', '**/*.test.ts'],
       rules: {
         ...common.testRules,
-        ...tempRules,
-        ...tempTypescriptRules,
+        ...extraJSRules,
+        ...extraTypescriptRules,
       },
     },
   ],

packages/build/src/download-center/config.spec.ts

@@ -10,7 +10,8 @@ import {
   createAndPublishDownloadCenterConfig,
   createJsonFeedEntry,
 } from './config';
-import { Server as HTTPServer, createServer as createHTTPServer } from 'http';
+import { createServer as createHTTPServer } from 'http';
+import type { Server as HTTPServer } from 'http';
 import { once } from 'events';
 import path from 'path';
 import fetch from 'node-fetch';

packages/build/src/homebrew/generate-formula.spec.ts

@@ -29,8 +29,8 @@ class Mongosh < Formula
   end
 
   test do
-    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \"mongodb://0.0.0.0:1\" 2>&1", 1)
-    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \"print('#ok#')\"")
+    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \\"mongodb://0.0.0.0:1\\" 2>&1", 1)
+    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \\"print('#ok#')\\"")
   end
 end`;
 
@@ -75,8 +75,8 @@ class Mongosh < Formula
   end
 
   test do
-    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \"mongodb://0.0.0.0:1\" 2>&1", 1)
-    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \"print('#ok#')\"")
+    assert_match "ECONNREFUSED 0.0.0.0:1", shell_output("#{bin}/mongosh \\"mongodb://0.0.0.0:1\\" 2>&1", 1)
+    assert_match "#ok#", shell_output("#{bin}/mongosh --nodb --eval \\"print('#ok#')\\"")
   end
 end`;
     expect(

packages/build/src/homebrew/generate-formula.ts

@@ -11,8 +11,8 @@ export async function generateUpdatedFormula(
     'master'
   );
 
-  const urlMatch = /url \"([^"]+)\"/g.exec(currentFormula.content);
-  const shaMatch = /sha256 \"([^"]+)\"/g.exec(currentFormula.content);
+  const urlMatch = /url "([^"]+)"/g.exec(currentFormula.content);
+  const shaMatch = /sha256 "([^"]+)"/g.exec(currentFormula.content);
 
   if (!urlMatch || !shaMatch) {
     throw new Error(
@@ -45,9 +45,9 @@ export async function generateUpdatedFormula(
   }
 
   let newFormula = currentFormula.content;
-  newFormula = newFormula.replace(/url \"([^"]+)\"/g, `url "${newUrl}"`);
+  newFormula = newFormula.replace(/url "([^"]+)"/g, `url "${newUrl}"`);
   newFormula = newFormula.replace(
-    /sha256 \"([^"]+)\"/g,
+    /sha256 "([^"]+)"/g,
     `sha256 "${context.sha}"`
   );
   return newFormula;

packages/cli-repl/src/crypt-library-paths.ts

@@ -24,6 +24,7 @@ export async function getCryptLibraryPaths(
 ): Promise<CryptLibraryPathResult> {
   const execPath = pretendProcessExecPathForTesting ?? process.execPath;
 
+  // eslint-disable-next-line @typescript-eslint/consistent-type-imports
   let getCryptSharedLibraryVersion: typeof import('mongodb-crypt-library-version');
   try {
     getCryptSharedLibraryVersion = require('mongodb-crypt-library-version');

packages/cli-repl/src/mongosh-repl.ts

@@ -485,6 +485,7 @@ class MongoshNodeRepl implements EvaluationListener {
    *
    * @param _initializationToken A value obtained by calling {@link MongoshNodeRepl.initialize}.
    */
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   async startRepl(_initializationToken: InitializationToken): Promise<void> {
     this.started = true;
     const { repl } = this.runtimeState();

packages/cli-repl/test/fixtures/load/hello1.js

@@ -1 +1,2 @@
+/* eslint-disable no-undef */
 print('hello one');

packages/cli-repl/test/fixtures/load/hello2.js

@@ -1 +1,2 @@
+/* eslint-disable no-undef */
 print('hello two');

packages/cli-repl/test/fixtures/load/insertintotest.js

@@ -1,2 +1,3 @@
+/* eslint-disable no-undef */
 insertTestCollection = db.getSiblingDB('test').getCollection('insertTest' + ((Math.random() * 100000) | 0));
 print('Inserted:', insertTestCollection.insertOne({}).insertedId)

packages/cli-repl/test/fixtures/load/printisinteractive.js

@@ -1 +1,2 @@
+/* eslint-disable no-undef */
 print(`isInteractive=${isInteractive()}`)