refactor: move to mongosh-repl and use a hotfixed array

Author: gagik

packages/cli-repl/src/cli-repl.ts

@@ -54,10 +54,6 @@ import type {
   DevtoolsProxyOptions,
 } from '@mongodb-js/devtools-proxy-support';
 import { useOrCreateAgent } from '@mongodb-js/devtools-proxy-support';
-import type { TypeSignature } from '@mongosh/shell-api';
-import { signatures } from '@mongosh/shell-api';
-import util from 'util';
-import { formatOutput } from './format-output';
 
 /**
  * Connecting text key.
@@ -500,8 +496,6 @@ export class CliRepl implements MongoshIOProvider {
       });
     }
 
-    this.setupHistoryCommand();
-
     Editor.create({
       input: this.input,
       vscodeDir: this.shellHomeDirectory.rcPath('.vscode'),
@@ -916,47 +910,6 @@ export class CliRepl implements MongoshIOProvider {
     return this.shellHomeDirectory.roamingPath('mongosh_repl_history');
   }
 
-  /** Returns the history of commands. */
-  setupHistoryCommand(): void {
-    const getHistory = () => {
-      const replHistory: string[] = (
-        this.mongoshRepl.runtimeState().repl as any
-      ).history;
-      const formattedHistory =
-        // Remove the history call from the formatted history
-        replHistory.slice(1, replHistory.length).reverse();
-
-      return {
-        ...formattedHistory,
-        [util.inspect.custom]: () => {
-          return formatOutput(
-            {
-              // eslint-disable-next-line @typescript-eslint/no-explicit-any
-              value: formattedHistory,
-            },
-            { colors: true, maxArrayLength: Infinity }
-          );
-        },
-      };
-    };
-
-    getHistory.isDirectShellCommand = true;
-    getHistory.returnsPromise = true;
-    getHistory.acceptsRawInput = true;
-
-    this.mongoshRepl.runtimeState().context.history =
-      // eslint-disable-next-line @typescript-eslint/no-explicit-any
-      (this.mongoshRepl.runtimeState().instanceState.shellApi as any).history =
-        getHistory;
-    // eslint-disable-next-line @typescript-eslint/no-explicit-any
-    (signatures.ShellApi.attributes as any).history = {
-      type: 'function',
-      returnsPromise: true,
-      isDirectShellCommand: true,
-      acceptsRawInput: true,
-    } as TypeSignature;
-  }
-
   /**
    * Implements getConfig from the {@link ConfigProvider} interface.
    */

packages/cli-repl/src/mongosh-repl.ts

@@ -9,10 +9,12 @@ import type {
   EvaluationListener,
   OnLoadResult,
   ShellCliOptions,
+  TypeSignature,
 } from '@mongosh/shell-api';
 import {
   ShellInstanceState,
   getShellApiType,
+  signatures,
   toShellResult,
 } from '@mongosh/shell-api';
 import type { ShellResult } from '@mongosh/shell-evaluator';
@@ -47,6 +49,7 @@ import { markTime } from './startup-timing';
 import type { Context } from 'vm';
 import { Script, createContext, runInContext } from 'vm';
 import { installPasteSupport } from './repl-paste-support';
+import util from 'util';
 
 declare const __non_webpack_require__: any;
 
@@ -365,6 +368,8 @@ class MongoshNodeRepl implements EvaluationListener {
     await this.finishInitializingNodeRepl();
     instanceState.setCtx(context);
 
+    this.setupHistoryCommand();
+
     if (!this.shellCliOptions.nodb && !this.shellCliOptions.quiet) {
       // cf. legacy shell:
       // https://github.com/mongodb/mongo/blob/a6df396047a77b90bf1ce9463eecffbee16fb864/src/mongo/shell/mongo_main.cpp#L1003-L1026
@@ -391,6 +396,44 @@ class MongoshNodeRepl implements EvaluationListener {
     return { __initialized: 'yes' };
   }
 
+  setupHistoryCommand(): void {
+    const getHistory = () => {
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      const replHistory: string[] = (this.runtimeState().repl as any).history;
+      const formattedHistory =
+        // Remove the history call from the formatted history
+        replHistory.slice(1, replHistory.length).reverse();
+
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      formattedHistory[util.inspect.custom as any] = (() => {
+        return formatOutput(
+          {
+            // The value of the format has to be a copy of the history to avoid circular references.
+            value: formattedHistory.concat(),
+          },
+          { colors: true, maxArrayLength: Infinity }
+        );
+        // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      }) as any;
+      return formattedHistory;
+    };
+
+    getHistory.isDirectShellCommand = true;
+    getHistory.returnsPromise = false;
+    getHistory.acceptsRawInput = true;
+
+    this.runtimeState().context.history =
+      // eslint-disable-next-line @typescript-eslint/no-explicit-any
+      (this.runtimeState().instanceState.shellApi as any).history = getHistory;
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
+    (signatures.ShellApi.attributes as any).history = {
+      type: 'function',
+      returnsPromise: true,
+      isDirectShellCommand: true,
+      acceptsRawInput: true,
+    } as TypeSignature;
+  }
+
   private async finishInitializingNodeRepl(): Promise<void> {
     const { repl, instanceState } = this.runtimeState();
     if (!repl) return;