Adding s3 module tests

Author: durran

packages/build/package.json

@@ -35,5 +35,11 @@
     "handlebars": "^4.7.6",
     "pkg": "^4.4.3",
     "tar": "^6.0.1"
+  },
+  "devDependencies": {
+    "chai": "^4.2.0",
+    "mocha": "^6.2.1",
+    "sinon": "^7.5.0",
+    "sinon-chai": "^3.4.0"
   }
 }

packages/build/src/s3.spec.ts

@@ -1,11 +1,33 @@
+import { expect } from 'chai';
+import sinon from 'sinon';
+import upload from './s3';
+
 describe('s3 module', () => {
   describe('.upload', () => {
+    const params = { ACL: 'public-read' };
+
     context('when the upload errors', () => {
+      const uploadMock = sinon.mock().withArgs(params).yields('error', {});
+      const s3Stub = { upload: uploadMock };
 
+      it('rejects the promise with the error', (done) => {
+        upload(params, s3Stub).catch((error) => {
+          expect(error).to.equal('error');
+          uploadMock.verify();
+          done();
+        });
+      });
     });
 
     context('when the upload succeeds', () => {
+      const uploadMock = sinon.mock().withArgs(params).yields(null, {});
+      const s3Stub = { upload: uploadMock };
 
+      it('resolves the promise with the data', async() => {
+        const data = await upload(params, s3Stub);
+        expect(data).to.deep.equal({});
+        uploadMock.verify();
+      });
     });
   });
 });

packages/build/src/s3.ts

@@ -8,7 +8,7 @@ import S3 from 'aws-sdk/clients/s3';
  *
  * @returns {Promise} - A Promise.
  */
-const upload = (params: any, s3: S3): Promise<any> => {
+const upload = (params: any, s3: any): Promise<any> => {
   return new Promise((resolve, reject) => {
     s3.upload(params, (error, data) => {
       if (error) {