fix(service-provider-core): skip directConnection in URL when loadBalanced is set (#997)

Author: addaleax

packages/service-provider-core/src/uri-generator.spec.ts

@@ -125,6 +125,14 @@ describe('uri-generator.generate-uri', () => {
         });
       });
 
+      context('including loadBalanced', () => {
+        const uri = 'mongodb://192.0.0.1:27018/db?loadBalanced=true';
+        const options = { connectionSpecifier: uri };
+        it('does not add the directConnection parameter', () => {
+          expect(generateUri(options)).to.equal(uri);
+        });
+      });
+
       context('including explicit directConnection', () => {
         const uri = 'mongodb://192.0.0.1:27018/db?directConnection=false';
         const options = { connectionSpecifier: uri };

packages/service-provider-core/src/uri-generator.ts

@@ -218,7 +218,7 @@ function generateUriNormalized(options: CliOptions): ConnectionString {
 function addShellConnectionStringParameters(uri: ConnectionString): ConnectionString {
   uri = uri.clone();
   const params = uri.searchParams;
-  if (!params.has('replicaSet') && !params.has('directConnection') && uri.hosts.length === 1) {
+  if (!params.has('replicaSet') && !params.has('directConnection') && !params.has('loadBalanced') && uri.hosts.length === 1) {
     params.set('directConnection', 'true');
   }
   if (!params.has('tlsCertificateFile') && params.has('tlsCertificateKeyFile')) {