fix: use reproducible code and add tests

Author: gagik

packages/service-provider-core/src/printable-bson.spec.ts

@@ -95,6 +95,34 @@ describe('BSON printers', function () {
     ).to.equal("MD5('0123456789abcdef0123456789abcdef')");
   });
 
+  describe('with Vector types', function () {
+    it('formats Int8Array correctly', function () {
+      expect(
+        inspect(bson.Binary.fromInt8Array(new Int8Array([1, 2, 3])))
+      ).to.equal('Binary.fromInt8Array(new Int8Array([ 1, 2, 3 ]))');
+    });
+
+    it('formats PackedBits correctly', function () {
+      expect(
+        inspect(bson.Binary.fromPackedBits(new Uint8Array([1, 2, 3])))
+      ).to.equal('Binary.fromPackedBits(new Uint8Array([ 1, 2, 3 ]))');
+    });
+
+    it('formats Float32Array correctly', function () {
+      expect(
+        inspect(
+          bson.Binary.fromFloat32Array(
+            new Float32Array([1.1111, 2.2222, 3.3333])
+          ),
+          { compact: true }
+        )
+      ).matches(
+        // Precision is lost because of float handling, so we use regex to match
+        /Binary.fromFloat32Array\(new Float32Array\(\[ 1\.1\d*, 2\.2\d*, 3\.3\d* \]\)\)/
+      );
+    });
+  });
+
   it('formats any other value with the new format using createfromBase64', function () {
     expect(
       inspect(bson.Binary.createFromBase64('SGVsbG8sIFdvcmxkIQo='))

packages/service-provider-core/src/printable-bson.ts

@@ -1,3 +1,4 @@
+import { satisfies } from 'semver';
 import { bson as BSON } from './bson-export';
 import type { InspectOptionsStylized, CustomInspectFunction } from 'util';
 import { inspect as utilInspect } from 'util';
@@ -26,11 +27,11 @@ function makeClasslessInspect<K extends BSONClassKey>(
 ): CustomInspectFunction {
   const originalInspect = BSON[className].prototype.inspect;
   return function (
-    this: typeof originalInspect,
+    this: (typeof BSON)[typeof className]['prototype'],
     ...args: Parameters<typeof originalInspect>
   ) {
     return removeNewFromInspectResult(originalInspect.apply(this, args));
-  } as CustomInspectFunction;
+  } satisfies CustomInspectFunction;
 }
 
 const binaryInspect = makeClasslessInspect('Binary');
@@ -49,7 +50,7 @@ const binaryVectorInspect = function (
           // These arrays can be very large, so would prefer to use the default options instead.
           maxArrayLength: utilInspect.defaultOptions.maxArrayLength,
         })
-      )})`;
+      )}))`;
     case BSON.Binary.VECTOR_TYPE.Float32:
       return `Binary.fromFloat32Array(new Float32Array(${removeTypedArrayPrefixFromInspectResult(
         utilInspect(this.toFloat32Array(), {
@@ -58,16 +59,16 @@ const binaryVectorInspect = function (
           // These arrays can be very large, so would prefer to use the default options instead.
           maxArrayLength: utilInspect.defaultOptions.maxArrayLength,
         })
-      )})`;
+      )}))`;
     case BSON.Binary.VECTOR_TYPE.PackedBit:
-      return `Binary.fromPackedBitArray(new Uint8Array(${removeTypedArrayPrefixFromInspectResult(
+      return `Binary.fromPackedBits(new Uint8Array(${removeTypedArrayPrefixFromInspectResult(
         utilInspect(this.toPackedBits(), {
           depth,
           ...options,
           // These arrays can be very large, so would prefer to use the default options instead.
           maxArrayLength: utilInspect.defaultOptions.maxArrayLength,
         })
-      )})`;
+      )}))`;
     default:
       return binaryInspect.call(this, depth, options);
   }