fix(service-provider-server): accept functions in createView MONGOSH-585 (#655)

Author: addaleax

packages/service-provider-server/src/cli-service-provider.spec.ts

@@ -726,7 +726,7 @@ describe('CliServiceProvider', () => {
     it('executes the command', async() => {
       const result = await serviceProvider.createCollection('db1', 'newcoll', {});
       expect(result).to.deep.equal({ ok: 1 });
-      expect(dbStub.createCollection).to.have.been.calledOnceWith('newcoll', {});
+      expect(dbStub.createCollection).to.have.been.calledOnceWith('newcoll', DEFAULT_BASE_OPTS);
       expect(clientStub.db).to.have.been.calledOnceWith('db1');
     });
   });

packages/service-provider-server/src/cli-service-provider.ts

@@ -1085,6 +1085,7 @@ class CliServiceProvider extends ServiceProviderCore implements ServiceProvider
     options: CreateCollectionOptions = {},
     dbOptions?: DbOptions
   ): Promise<{ ok: number }> {
+    options = { ...this.baseCmdOptions, ...options };
     await this.db(dbName, dbOptions).createCollection(
       collName, options
     );

packages/shell-api/src/integration.spec.ts

@@ -983,6 +983,34 @@ describe('Shell API (integration)', function() {
           }
         ]);
       });
+      context('features only available on mongodb 4.4+', () => {
+        skipIfServerVersion(testServer, '< 4.4');
+        it('creates a view that potentially contains JS functions in its pipeline', async() => {
+          const pipeline = (body: any) => [{
+            '$set': {
+              'name_md5': { '$function': { 'lang': 'js', 'args': ['$name'], 'body': body } }
+            }
+          }];
+          const fn = compileExpr `function (val) {
+            return hex_md5(val);
+          }`;
+          expect(
+            await database.createView(
+              'view',
+              'source',
+              pipeline(fn)
+            )
+          ).to.deep.equal({ ok: 1 });
+          const views = await serviceProvider.find(dbName, 'system.views', {}).toArray();
+          expect(JSON.parse(JSON.stringify(views))).to.deep.equal([
+            {
+              _id: `${dbName}.view`,
+              viewOn: 'source',
+              pipeline: pipeline({ code: fn.toString() })
+            }
+          ]);
+        });
+      });
     });
   });