Skip to content

Commit 9a40e24

Browse files
authored
fix(node-runtime-worker-thread): externalize system-ca and deps COMPASS-4105 (#1221)
In order to be usable in Compass, system-ca and its addon dependencies need to be externalized in the webpack configuration. Theoretically, it might be enough to only externalize the addons; however, since system-ca prefers to use worker threads for loading certificates asynchronously on macOS and Windows, and we need to externalize *something*, it makes sense to do it on the system-ca level.
1 parent 4964265 commit 9a40e24

File tree

4 files changed

+47
-3
lines changed

4 files changed

+47
-3
lines changed
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
1-
ignores: ['webpack-cli']
2-
skip-missing: true
1+
ignores: ['webpack-cli', 'system-ca']
2+
skip-missing: true

packages/node-runtime-worker-thread/package-lock.json

Lines changed: 42 additions & 0 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/node-runtime-worker-thread/package.json

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@
4242
"webpack-cli": "^4.3.1"
4343
},
4444
"dependencies": {
45-
"interruptor": "^1.0.1"
45+
"interruptor": "^1.0.1",
46+
"system-ca": "^1.0.2"
4647
}
4748
}

packages/node-runtime-worker-thread/webpack.config.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -44,6 +44,7 @@ const config = {
4444
snappy: 'commonjs2 snappy',
4545
interruptor: 'commonjs2 interruptor',
4646
'os-dns-native': 'commonjs2 os-dns-native',
47+
'system-ca': 'commonjs2 system-ca'
4748
}
4849
};
4950

0 commit comments

Comments
 (0)