Skip to content

Commit a38a173

Browse files
authored
fix(shell-evaluator): fix exposed asyncRewrite fn for benchmarks (#1922)
Painfully obvious bug in 0491491 :) Renamed the benchmark test and fixed it to account for the (now very) different performance measurements after the fix.
1 parent 7832ccf commit a38a173

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

packages/cli-repl/src/smoke-tests.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ export async function runSmokeTests({
176176
perfTestIterations: 0,
177177
},
178178
{
179-
name: 'async_rewrite',
179+
name: 'async_rewrite_foreach',
180180
input:
181-
'for (let i = 0; i < 100; i++) __asyncRewrite(String([].forEach)); print("done")',
181+
'for (let i = 0; i < 100; i++) __asyncRewrite(String([].forEach).replace("function", "function forEach")); print("done")',
182182
output: /done/,
183183
includeStderr: false,
184184
testArgs: ['--exposeAsyncRewriter', '--nodb'],

packages/shell-evaluator/src/shell-evaluator.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,8 @@ class ShellEvaluator<EvaluationResultType = ShellResult> {
9393
}
9494

9595
if (this.exposeAsyncRewriter) {
96-
(context as any).__asyncRewrite = () => this.asyncWriter.process(input);
96+
(context as any).__asyncRewrite = (rewriteInput: string) =>
97+
this.asyncWriter.process(rewriteInput);
9798
}
9899

99100
this.markTime?.(TimingCategories.AsyncRewrite, 'start async rewrite');

0 commit comments

Comments
 (0)