Revert "Fix eslint in vscode (#1099)" (#1105)

This reverts commit c437255.

This fixes Windows CI:

    [2021/09/13 10:44:59.161] > npm run lint
    [2021/09/13 10:44:59.161] > @mongosh/[email protected] lint C:\data\mci\abacfdf08bad6c5c588fc6f7d2007707\src\packages\errors
    [2021/09/13 10:44:59.161] > eslint --report-unused-disable-directives "./{src,test}/**/*.{js,ts,tsx}"
    [2021/09/13 10:44:59.161] C:\data\mci\abacfdf08bad6c5c588fc6f7d2007707\src\packages\errors\src\common-errors.ts
    [2021/09/13 10:44:59.161]   0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
    [2021/09/13 10:44:59.161] The file does not match your project config: C:\data\mci\abacfdf08bad6c5c588fc6f7d2007707\src\packages\errors\src\common-errors.ts.
    [2021/09/13 10:44:59.161] The file must be included in at least one of the projects provided
    [2021/09/13 10:44:59.161] C:\data\mci\abacfdf08bad6c5c588fc6f7d2007707\src\packages\errors\src\index.spec.ts
    [2021/09/13 10:44:59.161]   0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
    [2021/09/13 10:44:59.161] The file does not match your project config: C:\data\mci\abacfdf08bad6c5c588fc6f7d2007707\src\packages\errors\src\index.spec.ts.
    [2021/09/13 10:44:59.161] The file must be included in at least one of the projects provided
    [2021/09/13 10:44:59.161] C:\data\mci\abacfdf08bad6c5c588fc6f7d2007707\src\packages\errors\src\index.ts
    [2021/09/13 10:44:59.161]   0:0  error  Parsing error: "parserOptions.project" has been set for @typescript-eslint/parser.
    [2021/09/13 10:44:59.161] The file does not match your project config: C:\data\mci\abacfdf08bad6c5c588fc6f7d2007707\src\packages\errors\src\index.ts.
    [2021/09/13 10:44:59.161] The file must be included in at least one of the projects provided
    [2021/09/13 10:44:59.161] ✖ 3 problems (3 errors, 0 warnings)
    [2021/09/13 10:44:59.161] lerna ERR! npm run check stderr:
    [2021/09/13 10:44:59.161] npm ERR! code ELIFECYCLE
    [2021/09/13 10:44:59.161] npm ERR! errno 1
    [2021/09/13 10:44:59.161] npm ERR! @mongosh/[email protected] lint: `eslint --report-unused-disable-directives "./{src,test}/**/*.{js,ts,tsx}"`

Author: addaleax

config/eslintrc.base.js

@@ -1,53 +1,49 @@
-const jsRules = {
-  'object-curly-spacing': [2, 'always'],
-  'no-empty-function': 0,
-  'valid-jsdoc': 0,
-  'react/sort-comp': 0, // does not seem work as expected with typescript
-  'mocha/no-skipped-tests': 1,
-  'mocha/no-exclusive-tests': 2,
-  'semi': [2, 'always'],
-  'no-console': [1, { allow: ['warn', 'error', 'info'] }],
-  'no-shadow': 0,
-  'no-use-before-define': 0,
-  'no-cond-assign': [2, 'except-parens']
-}
+const typescriptEslintEslintPlugin = require('@typescript-eslint/eslint-plugin');
 
-const tsRules = {
-  '@typescript-eslint/no-empty-function': 0,
-  '@typescript-eslint/no-use-before-define': 0,
-  '@typescript-eslint/no-explicit-any': 0,
-  '@typescript-eslint/no-var-requires': 0, // seems necessary to import less files
-  '@typescript-eslint/no-unused-vars': 2,
-  '@typescript-eslint/no-floating-promises': 2,
-  '@typescript-eslint/await-thenable': 2,
-  '@typescript-eslint/require-await': 2,
-  '@typescript-eslint/explicit-module-boundary-types': 0,
-  '@typescript-eslint/ban-types': 0,
-  'semi': 0,
-  '@typescript-eslint/semi': [2, 'always']
-};
+// ovrerrides do not work with extends
+const ruleOverridesForJs = Object.keys(typescriptEslintEslintPlugin.rules).reduce(
+  (overrides, rule) => ({ ...overrides, [`@typescript-eslint/${rule}`]: 0 }), {}
+);
 
 module.exports = {
   plugins: ['mocha'],
-  overrides: [{
-    files: ['**/*.js', '**/*.jsx'],
-    extends: [
-      'eslint-config-mongodb-js/react'
-    ],
-    rules: {
-      ...jsRules
-    }
+  parser: '@typescript-eslint/parser',
+  parserOptions: {
+    project: './tsconfig.lint.json'
+  },
+  extends: [
+    'eslint-config-mongodb-js/react',
+    'plugin:@typescript-eslint/recommended'
+  ],
+  rules: {
+    'object-curly-spacing': [2, 'always'],
+    'no-empty-function': 0,
+    'valid-jsdoc': 0,
+    'react/sort-comp': 0, // does not seem work as expected with typescript
+    '@typescript-eslint/no-empty-function': 0,
+    '@typescript-eslint/no-use-before-define': 0,
+    '@typescript-eslint/no-explicit-any': 0,
+    '@typescript-eslint/no-var-requires': 0, // seems necessary to import less files
+    '@typescript-eslint/no-unused-vars': 2,
+    '@typescript-eslint/no-floating-promises': 2,
+    '@typescript-eslint/await-thenable': 2,
+    '@typescript-eslint/require-await': 2,
+    '@typescript-eslint/explicit-module-boundary-types': 0,
+    '@typescript-eslint/ban-types': 0,
+    'mocha/no-skipped-tests': 1,
+    'mocha/no-exclusive-tests': 2,
+    'semi': 0,
+    '@typescript-eslint/semi': [2, 'always'],
+    'no-console': [1, { allow: ['warn', 'error', 'info'] }],
+    'no-shadow': 0,
+    'no-use-before-define': 0,
+    'no-cond-assign': [2, 'except-parens']
   },
-  {
-    files: ['**/*.ts', '**/*.tsx'],
-    parser: '@typescript-eslint/parser',
-    extends: [
-      'eslint-config-mongodb-js/react',
-      'plugin:@typescript-eslint/recommended'
-    ],
+  overrides: [{
+    files: ['**/*.js'],
     rules: {
-      ...jsRules,
-      ...tsRules
+      ...ruleOverridesForJs,
+      semi: [2, 'always']
     }
   }]
 };

packages/async-rewriter2/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/autocomplete/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/browser-repl/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/browser-runtime-core/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/browser-runtime-electron/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/build/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/cli-repl/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/errors/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');

packages/history/.eslintrc.js

@@ -1,8 +1 @@
-module.exports = {
-  ...require('../../config/eslintrc.base'),
-  root: true,
-  parserOptions: {
-    tsconfigRootDir: __dirname,
-    project: './tsconfig.lint.json'
-  }
-};
+module.exports = require('../../config/eslintrc.base');