feat!(mongodb-log-writer): add ability to disable logging MONGOSH-1988

Author: gagik

packages/cli-repl/src/cli-repl.spec.ts

@@ -1519,6 +1519,13 @@ describe('CliRepl', function () {
           expect(totalEventsTracked).to.equal(4);
         });
 
+        it('uses the disable logging setting', function () {
+          cliReplOptions.disableLogging = true;
+          cliRepl = new CliRepl(cliReplOptions);
+
+          expect(cliRepl.logWriter?.isDisabled).equals(true);
+        });
+
         it('sends out telemetry data for command line scripts', async function () {
           cliReplOptions.shellCliOptions.eval = ['db.hello()'];
           cliRepl = new CliRepl(cliReplOptions);

packages/cli-repl/src/cli-repl.ts

@@ -97,6 +97,8 @@ export type CliReplOptions = {
   onExit: (code?: number) => never;
   /** Optional analytics override options. */
   analyticsOptions?: AnalyticsOptions;
+  /** Disables writing logs. */
+  disableLogging?: boolean;
 } & Pick<MongoshNodeReplOptions, 'nodeReplOptions'>;
 
 /** The set of config options that is *always* available in config files stored on the file system. */

packages/logging/src/multi-set.ts

@@ -0,0 +1,22 @@
+/**
+ * A helper class for keeping track of how often specific events occurred.
+ */
+export class MultiSet<T extends Record<string, unknown>> {
+  _entries: Map<string, number> = new Map();
+
+  add(entry: T): void {
+    const key = JSON.stringify(Object.entries(entry).sort());
+    this._entries.set(key, (this._entries.get(key) ?? 0) + 1);
+  }
+
+  clear(): void {
+    this._entries.clear();
+  }
+
+  *[Symbol.iterator](): Iterator<[T, number]> {
+    for (const [key, count] of this._entries) {
+      // eslint-disable-next-line @typescript-eslint/no-unsafe-argument
+      yield [Object.fromEntries(JSON.parse(key)) as T, count];
+    }
+  }
+}

packages/logging/src/setup-logger-and-telemetry.spec.ts

@@ -6,6 +6,7 @@ import { EventEmitter } from 'events';
 import { MongoshInvalidInputError } from '@mongosh/errors';
 import type { MongoshBus } from '@mongosh/types';
 import { toSnakeCase } from './setup-logger-and-telemetry';
+import type { Writable } from 'stream';
 
 describe('toSnakeCase', function () {
   const useCases = [
@@ -37,15 +38,19 @@ describe('setupLoggerAndTelemetry', function () {
   const userId = '53defe995fa47e6c13102d9d';
   const logId = '5fb3c20ee1507e894e5340f3';
 
-  const logger = new MongoLogWriter(logId, `/tmp/${logId}_log`, {
-    write(chunk: string, cb: () => void) {
-      logOutput.push(JSON.parse(chunk));
-      cb();
-    },
-    end(cb: () => void) {
-      cb();
-    },
-  } as any);
+  const logger = new MongoLogWriter({
+    logId,
+    logFilePath: `/tmp/${logId}_log`,
+    target: {
+      write(chunk: string, cb: () => void) {
+        logOutput.push(JSON.parse(chunk));
+        cb();
+      },
+      end(cb: () => void) {
+        cb();
+      },
+    } as Writable,
+  });
   const analytics = {
     identify(info: any) {
       analyticsOutput.push(['identify', info]);