check if bump is necessary for installs

Author: gagik

.evergreen/install-npm-deps.sh

@@ -31,7 +31,5 @@ npm run mark-ci-required-optional-dependencies
 # along with its types, but npm wouldn't try and compile the addon
 (npm ci && test -e node_modules/mongodb-client-encryption) || npm ci --ignore-scripts
 
-npm run evergreen-release bump
-
 echo "npm packages after installation"
 npm ls || true

package.json

@@ -71,7 +71,7 @@
     "prepare": "husky",
     "precommit": "precommit",
     "preinstall": "node scripts/sort-workspaces.js",
-    "bump-packages": "npm run bump --workspace @mongosh/build"
+    "bump-packages": "npm run bump-packages --workspace @mongosh/build"
   },
   "config": {
     "unsafe-perm": true

packages/build/src/npm-packages/bump.ts

@@ -1,16 +1,64 @@
 import { spawnSync } from '../helpers';
 import { PROJECT_ROOT } from './constants';
 
-const PACKAGES_TO_SKIP_BUMPING = ['mongosh', '@mongosh/cli-repl'];
+import { promises as fs } from 'fs';
+import path from 'path';
+import { getPackagesInTopologicalOrder } from '@mongodb-js/monorepo-tools';
 
+/** Packages which get bumped only as part of the mongosh release. */
+const MONGOSH_RELEASE_PACKAGES = ['mongosh', '@mongosh/cli-repl'];
+
+/** This bumps only the main mongosh release packages to the set version. */
+export async function bumpMongosh(version: string): Promise<void> {
+  console.info(`mongosh: Bumping package versions to ${version}`);
+  const monorepoRootPath = path.resolve(__dirname, '..', '..', '..', '..');
+  const packages = await getPackagesInTopologicalOrder(monorepoRootPath);
+
+  const workspaceNames = packages
+    .map((p) => p.name)
+    .filter((name) => MONGOSH_RELEASE_PACKAGES.includes(name));
+
+  const locations = [monorepoRootPath, ...packages.map((p) => p.location)];
+
+  for (const location of locations) {
+    const packageJsonPath = path.join(location, 'package.json');
+    const packageJson = JSON.parse(await fs.readFile(packageJsonPath, 'utf8'));
+
+    packageJson.version = version;
+    for (const grouping of [
+      'dependencies',
+      'devDependencies',
+      'optionalDependencies',
+      'peerDependencies',
+    ]) {
+      if (!packageJson[grouping]) {
+        continue;
+      }
+
+      for (const name of Object.keys(packageJson[grouping])) {
+        if (!workspaceNames.includes(name)) {
+          continue;
+        }
+        packageJson[grouping][name] = version;
+      }
+    }
+
+    await fs.writeFile(
+      packageJsonPath,
+      JSON.stringify(packageJson, null, 2) + '\n'
+    );
+  }
+}
+
+/** Bump packages without setting a new version of mongosh. */
 export function bumpNpmPackages() {
-  spawnSync('npx', ['bump-monorepo-packages'], {
+  spawnSync('bump-monorepo-packages', [], {
     stdio: 'inherit',
     cwd: PROJECT_ROOT,
     encoding: 'utf8',
     env: {
       ...process.env,
-      SKIP_BUMP_PACKAGES: PACKAGES_TO_SKIP_BUMPING.join(','),
+      SKIP_BUMP_PACKAGES: MONGOSH_RELEASE_PACKAGES.join(','),
     },
   });
 }

packages/build/src/release.ts

@@ -22,9 +22,11 @@ import { runUpload } from './run-upload';
 import { runSign } from './packaging/run-sign';
 import { runDownloadAndListArtifacts } from './run-download-and-list-artifacts';
 import { runDownloadCryptLibrary } from './packaging/run-download-crypt-library';
+import { bumpMongosh } from './npm-packages/bump';
 
 export type ReleaseCommand =
   | 'bump'
+  | 'bump-packages'
   | 'compile'
   | 'package'
   | 'sign'
@@ -55,6 +57,10 @@ export async function release(
   );
 
   if (command === 'bump') {
+    await bumpMongosh(config.version);
+    bumpNpmPackages();
+    return;
+  } else if (command === 'bump-packages') {
     // updates the version of internal packages to reflect the tagged one
     bumpNpmPackages();
     return;