Skip to content

Commit c4f06b9

Browse files
committed
Only mock for sharding information
1 parent f25c329 commit c4f06b9

File tree

1 file changed

+17
-22
lines changed

1 file changed

+17
-22
lines changed

packages/shell-api/src/helpers.spec.ts

Lines changed: 17 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -167,34 +167,15 @@ describe('getPrintableShardStatus', function () {
167167
configDatabase = new Database(mongo, 'config_test');
168168
expect(configDatabase.getName()).to.equal('config_test');
169169

170-
const mockedAdminDb = {
171-
aggregate: stub()
172-
.withArgs([{ $shardedDataDistribution: {} }])
173-
.resolves({
174-
toArray: stub().resolves(mockedShardedDataDistribution),
175-
}),
176-
};
177-
const getSiblingDB = stub();
178-
getSiblingDB.withArgs('admin').returns(mockedAdminDb);
179-
getSiblingDB.withArgs('config').returns(configDatabase);
180-
181-
configDatabase.getSiblingDB = getSiblingDB;
182-
configDatabase._maybeCachedHello = stub().returns({ msg: 'isdbgrid' });
183-
184170
const origRunCommandWithCheck = serviceProvider.runCommandWithCheck;
185-
serviceProvider.runCommandWithCheck = async (configDatabase, cmd) => {
171+
serviceProvider.runCommandWithCheck = async (db, cmd) => {
186172
if (cmd.hello) {
187173
return { ok: 1, msg: 'isdbgrid' };
188174
}
189-
if (configDatabase === 'admin' && cmd.balancerStatus) {
175+
if (db === 'admin' && cmd.balancerStatus) {
190176
return { ok: 1, inBalancerRound };
191177
}
192-
return origRunCommandWithCheck.call(
193-
serviceProvider,
194-
configDatabase,
195-
cmd,
196-
{}
197-
);
178+
return origRunCommandWithCheck.call(serviceProvider, db, cmd, {});
198179
};
199180

200181
await Promise.all(
@@ -222,6 +203,20 @@ describe('getPrintableShardStatus', function () {
222203
});
223204

224205
it('returns an object with sharding information', async function () {
206+
const mockedAdminDb = {
207+
aggregate: stub()
208+
.withArgs([{ $shardedDataDistribution: {} }])
209+
.resolves({
210+
toArray: stub().resolves(mockedShardedDataDistribution),
211+
}),
212+
};
213+
const getSiblingDB = stub();
214+
getSiblingDB.withArgs('admin').returns(mockedAdminDb);
215+
getSiblingDB.withArgs('config').returns(configDatabase);
216+
217+
configDatabase.getSiblingDB = getSiblingDB;
218+
configDatabase._maybeCachedHello = stub().returns({ msg: 'isdbgrid' });
219+
225220
const status = await getPrintableShardStatus(configDatabase, false);
226221
expect(status.shardingVersion.clusterId).to.be.instanceOf(bson.ObjectId);
227222
expect(status.shards.map(({ host }: { host: string }) => host)).to.include(

0 commit comments

Comments
 (0)