test fixes

Author: lerouxb

packages/browser-repl/src/components/shell.spec.tsx

@@ -1,3 +1,4 @@
+import util from 'util';
 import React, { useState, useEffect } from 'react';
 import sinon from 'sinon';
 import { render, screen, waitFor, configure } from '@testing-library/react';
@@ -168,19 +169,6 @@ describe('shell', function () {
     expect(filterEvaluateCalls(fakeRuntime.evaluate.args)).to.be.empty;
   });
 
-  it('calls onEditorChanged', function () {
-    const onEditorChanged = sinon.spy();
-
-    render(
-      <ShellWrapper runtime={fakeRuntime} onEditorChanged={onEditorChanged} />
-    );
-
-    expect(onEditorChanged.callCount).to.equal(1);
-    const editor = onEditorChanged.firstCall.args[0];
-    expect(editor.focus).to.exist;
-    expect(filterEvaluateCalls(fakeRuntime.evaluate.args)).to.be.empty;
-  });
-
   it('takes isOperationInProgress', function () {
     const isOperationInProgress = true;
 
@@ -532,7 +520,8 @@ describe('shell', function () {
       let called = 0;
       // eslint-disable-next-line @typescript-eslint/require-await
       fakeRuntime.getShellPrompt = async () => {
-        if (called++ <= 1) {
+        called++;
+        if (called === 1) {
           return 'mongos';
         }
         return 'rs0:primary';

packages/browser-repl/src/components/shell.tsx

@@ -206,7 +206,29 @@ const _Shell: ForwardRefRenderFunction<EditorRef | null, ShellProps> = (
   useImperativeHandle(
     ref,
     () => {
-      return editorRef.current as EditorRef;
+      return {
+        foldAll() {
+          return editorRef.current?.foldAll() ?? false;
+        },
+        unfoldAll() {
+          return editorRef.current?.unfoldAll() ?? false;
+        },
+        copyAll() {
+          return editorRef.current?.copyAll() ?? false;
+        },
+        prettify() {
+          return editorRef.current?.prettify() ?? false;
+        },
+        focus() {
+          return editorRef.current?.focus() ?? false;
+        },
+        applySnippet(template: string) {
+          return editorRef.current?.applySnippet(template) ?? false;
+        },
+        get editor() {
+          return editorRef.current?.editor ?? null;
+        },
+      };
     },
     []
   );
@@ -223,7 +245,7 @@ const _Shell: ForwardRefRenderFunction<EditorRef | null, ShellProps> = (
   >(() => noop);
 
   const focusEditor = useCallback(() => {
-    editorRef?.current?.focus();
+    editorRef.current?.focus();
   }, [editorRef]);
 
   const listener = useMemo<RuntimeEvaluationListener>(() => {
@@ -406,19 +428,6 @@ const _Shell: ForwardRefRenderFunction<EditorRef | null, ShellProps> = (
     shellInputContainerRef.current.scrollIntoView();
   }, [shellInputContainerRef]);
 
-  useEffect(() => {
-    scrollToBottom();
-
-    void updateShellPrompt().then(async () => {
-      if (initialEvaluate) {
-        const evalLines = normalizeInitialEvaluate(initialEvaluate);
-        for (const input of evalLines) {
-          await onInput(input);
-        }
-      }
-    });
-  }, [initialEvaluate, onInput, scrollToBottom, updateShellPrompt, output]);
-
   const onShellClicked = useCallback(
     (event: React.MouseEvent): void => {
       // Focus on input when clicking the shell background (not clicking output).
@@ -437,6 +446,21 @@ const _Shell: ForwardRefRenderFunction<EditorRef | null, ShellProps> = (
     return Promise.resolve(false);
   }, [isOperationInProgress, runtime]);
 
+  const initialEvaluateRef = useRef(initialEvaluate);
+
+  useEffect(() => {
+    scrollToBottom();
+
+    void updateShellPrompt().then(async () => {
+      if (initialEvaluateRef.current) {
+        const evalLines = normalizeInitialEvaluate(initialEvaluateRef.current);
+        for (const input of evalLines) {
+          await onInput(input);
+        }
+      }
+    });
+  }, [onInput, scrollToBottom, updateShellPrompt]);
+
   /* eslint-disable jsx-a11y/no-static-element-interactions */
   /* eslint-disable jsx-a11y/click-events-have-key-events */
   return (