Re-add check (#229)

* eslint fixes

* readd skip

* cr comments

* remove commented tests

Author: aherlihy

package.json

@@ -7,13 +7,11 @@
     "prebootstrap": "npm install",
     "bootstrap": "lerna bootstrap --concurrency=1",
     "clean": "lerna clean -y && rm -Rf node_modules",
-    "check": "echo",
-    "check-ci": "echo",
-    "lint": "lerna run check --since HEAD --exclude-dependents",
+    "check": "lerna run check --since HEAD --exclude-dependents",
+    "check-ci": "lerna run check",
     "test": "lerna run test",
     "test-ci": "lerna run test-ci",
     "compile-ts": "lerna run compile-ts",
-    "start-async": "lerna exec npm run start-async --scope @mongosh/cli-repl",
     "compile-cli": "lerna run compile-ts --scope @mongosh/cli-repl --include-dependencies",
     "prestart-cli": "npm run compile-cli",
     "start-cli": "lerna exec npm start --scope @mongosh/cli-repl",

packages/browser-repl/src/components/utils/inspect.spec.ts

@@ -37,19 +37,6 @@ describe('inspect', () => {
         inspect(undefined)
       ).to.equal('undefined');
     });
-
-    it.skip('inspects Symbol', () => {
-      expect(
-        inspect(Symbol('123'))
-      ).to.equal('Symbol(123)');
-    });
-
-    it.skip('inspects BigInt', () => {
-      expect(
-        // eslint-disable-next-line no-undef
-        inspect(BigInt(1))
-      ).to.equal('1n');
-    });
   });
 
   context('with BSON types', () => {

packages/browser-runtime-core/src/interpreter/interpreter.spec.ts

@@ -159,23 +159,25 @@ describe('Interpreter', () => {
       ).to.equal(3);
     });
 
-    it.skip('can redeclare a top level function as function', async() => {
-      expect(
-        await testEvaluate(
-          'function f() { return 1; }',
-          'function f() { return 2; }',
-          'f()'
-        )
-      ).to.equal(2);
-    });
-
-    it.skip('can redeclare a top level function as var', async() => {
-      expect(
-        await testEvaluate(
-          'function sum(a, b) { return a + b; }',
-          'var sum = 1'
-        )
-      ).to.equal(1);
+    describe.skip('redeclare top level vars', () => {
+      it('can redeclare a top level function as function', async() => {
+        expect(
+          await testEvaluate(
+            'function f() { return 1; }',
+            'function f() { return 2; }',
+            'f()'
+          )
+        ).to.equal(2);
+      });
+
+      it('can redeclare a top level function as var', async() => {
+        expect(
+          await testEvaluate(
+            'function sum(a, b) { return a + b; }',
+            'var sum = 1'
+          )
+        ).to.equal(1);
+      });
     });
 
     it('cannot re-declare a top level function as let', async() => {

packages/build/.eslintignore

@@ -0,0 +1,4 @@
+node_modules
+lib
+coverage
+

packages/build/.eslintrc.js

@@ -0,0 +1 @@
+module.exports = require('../../config/eslintrc.base');

packages/cli-repl/.eslintignore

@@ -1,3 +1,4 @@
 node_modules
 bin
 lib
+dist

packages/cli-repl/src/arg-mapper.spec.ts

@@ -23,16 +23,6 @@ describe('arg-mapper.mapCliToDriver', () => {
     });
   });
 
-  context('when cli args have disableImplicitSessions', () => {
-    const cliOptions: CliOptions = { disableImplicitSessions: true };
-
-    it.skip('maps to explicitlyIgnoreSession', () => {
-      expect(mapCliToDriver(cliOptions)).to.deep.equal({
-        explicitlyIgnoreSession: true
-      });
-    });
-  });
-
   context('when cli args have quiet', () => {
     const cliOptions: CliOptions = { quiet: true };
 

packages/i18n/.eslintignore

@@ -0,0 +1,2 @@
+node_modules
+lib

packages/i18n/.eslintrc.js

@@ -0,0 +1 @@
+module.exports = require('../../config/eslintrc.base');

packages/i18n/package.json

@@ -15,7 +15,9 @@
     "compile-ts": "tsc -p tsconfig.json",
     "prepublish": "npm run compile-ts",
     "test": "mocha --timeout 60000 --colors -r ts-node/register \"./src/**/*.spec.ts\"",
-    "test-ci": "mocha --timeout 60000 -r ts-node/register \"./src/**/*.spec.ts\""
+    "test-ci": "mocha --timeout 60000 -r ts-node/register \"./src/**/*.spec.ts\"",
+    "lint": "eslint \"**/*.{js,ts,tsx}\"",
+    "check": "npm run lint"
   },
   "license": "Apache-2.0",
   "publishConfig": {