Skip to content

Commit e8f0450

Browse files
authored
chore: drop node 16 from CI matrix MONGOSH-1898 (#2255)
1 parent 2536f15 commit e8f0450

File tree

8 files changed

+6624
-11091
lines changed

8 files changed

+6624
-11091
lines changed

.evergreen.yml

Lines changed: 6609 additions & 11033 deletions
Large diffs are not rendered by default.

.evergreen/InstallNode.ps1

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,9 @@ Get-ChildItem -Path $PSScriptRoot
2020
Set-Location -Path $node_dir
2121
Remove-Item .\npm
2222
Remove-Item .\npm.cmd
23+
if (Test-Path .\npm.ps1) { Remove-Item .\npm.ps1 }
2324
Remove-Item .\npx
2425
Remove-Item .\npx.cmd
26+
if (Test-Path .\npx.ps1) { Remove-Item .\npx.ps1 }
2527
Move-Item .\node_modules\npm -Destination .\node_modules\npm2
2628
.\node.exe .\node_modules\npm2\bin\npm-cli.js i -g npm@6

.evergreen/evergreen.yml.in

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@
22
const path = require('path');
33

44
const NODE_JS_VERSION_20 = require('./node-20-latest.json').version;
5-
const NODE_JS_VERSION_16 = require('./node-16-latest.json').version;
65

76
const MONGODB_VERSIONS = [
87
{ shortName: '42xc', versionSpec: '4.2.x' },
@@ -20,8 +19,7 @@ const MONGODB_VERSIONS = [
2019
{ shortName: 'latest', versionSpec: 'latest-alpha-enterprise' }
2120
];
2221
const NODE_VERSIONS = [
23-
{ shortName: '20', versionSpec: NODE_JS_VERSION_20, skipNodeVersionCheck: '' },
24-
{ shortName: '16', versionSpec: NODE_JS_VERSION_16, skipNodeVersionCheck: '' }
22+
{ shortName: '20', versionSpec: NODE_JS_VERSION_20, skipNodeVersionCheck: '' }
2523
];
2624

2725
const pathToPackages = path.join(__dirname, '..', 'packages');
@@ -1139,7 +1137,7 @@ tasks:
11391137

11401138
###
11411139
# UNIT TESTS
1142-
# E.g. test_m60xc_n16 stands for mongod 6.0.x, community edition, Node.js 16
1140+
# E.g. test_m60xc_n20 stands for mongod 6.0.x, community edition, Node.js 20
11431141
###
11441142
<% for (const { id, packageName } of ALL_UNIT_TESTS) { %>
11451143
- name: test_<% out(id) %>

.evergreen/install-node.sh

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,11 +2,7 @@ set -e
22
set -x
33
export BASEDIR="$PWD/.evergreen"
44

5-
if echo $NODE_JS_VERSION | grep -q ^16 ; then
6-
NPM_VERSION=9.9.2 # 9.9.3 does not install well on Windows
7-
else
8-
NPM_VERSION=10.8.3 # 10.9.0 does not install well on Windows
9-
fi
5+
NPM_VERSION=10.8.3 # 10.9.0 does not install well on Windows
106

117
if [ "$OS" == "Windows_NT" ]; then
128
powershell "$(cygpath -w "$BASEDIR")"/InstallNode.ps1

.evergreen/node-16-latest.json

Lines changed: 0 additions & 43 deletions
This file was deleted.

.github/workflows/cron-tasks.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,12 +35,12 @@ jobs:
3535

3636
- uses: actions/setup-node@v4
3737
with:
38-
node-version: ^16.x
38+
node-version: ^20.x
3939
cache: "npm"
4040

4141
- name: Install npm@8
4242
run: |
43-
npm install -g npm@8
43+
npm install -g npm@10
4444
4545
- name: Install Dependencies and Compile
4646
run: |

package-lock.json

Lines changed: 4 additions & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353
"create-purls-file": "node scripts/create-purls.js .sbom/dependencies.json .sbom/node-js-dep.json > .sbom/purls.txt",
5454
"preupdate-third-party-notices": "npm run create-dependency-sbom-lists",
5555
"update-third-party-notices": "mongodb-sbom-tools generate-3rd-party-notices --product='mongosh' --dependencies=.sbom/dependencies.json > THIRD_PARTY_NOTICES.md",
56-
"update-node-js-versions": "npx @pkgjs/nv ls v20 > .evergreen/node-20-latest.json && npx @pkgjs/nv ls v16 > .evergreen/node-16-latest.json",
56+
"update-node-js-versions": "npx @pkgjs/nv ls v20 > .evergreen/node-20-latest.json",
5757
"update-evergreen-config": "npm run test-evergreen-expansions && node .evergreen/generate-evergreen-yml.js .evergreen/evergreen.yml.in > .evergreen.yml",
5858
"update-cli-usage-text": "node scripts/update-cli-usage-text.js",
5959
"update-security-test-summary": "ts-node scripts/generate-security-test-summary.ts > docs/security-test-summary.md",
@@ -107,7 +107,6 @@
107107
"@types/which": "^1.3.2",
108108
"chai": "^4.2.0",
109109
"cross-env": "^6.0.3",
110-
"depcheck": "^1.4.7",
111110
"duplexpair": "^1.0.2",
112111
"find-up": "^5.0.0",
113112
"glob": "^10.3.12",
@@ -131,7 +130,9 @@
131130
"webpack-bundle-analyzer": "^4.7.0",
132131
"webpack-cli": "^4.3.1",
133132
"which": "^2.0.2",
134-
"yaml": "^1.10.0"
133+
"yaml": "^1.10.0",
134+
"depcheck": "^1.4.7",
135+
"@pkgjs/nv": "^0.2.2"
135136
},
136137
"optionalDependencies": {
137138
"lerna": "^8.1.8"

0 commit comments

Comments
 (0)