Skip to content

Commit f0708ff

Browse files
committed
chore: Fixes from PR comments
1 parent e182a1c commit f0708ff

File tree

4 files changed

+9
-9
lines changed

4 files changed

+9
-9
lines changed

.evergreen-nightly-driver.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,6 @@
22
parameters:
33
- key: mongodb_driver_version_override
44
value: nightly
5+
56
include:
67
- filename: .evergreen.yml

.evergreen/setup-env.sh

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,11 +71,11 @@ fi
7171
if [ `uname` = Linux ]; then
7272
export npm_config_unsafe_perm=true
7373
if [ "$NODE_JS_MAJOR_VERSION" = "24" ] ; then
74-
# This is a temporary fix until we upgrade our toolkit to 24.11+
75-
# More info: https://github.com/mongodb-js/devtools-toolchain/pull/10
76-
export NODE_OPTIONS="$NODE_OPTIONS --jitless"
77-
echo "[WARNING] Using jitless v8."
78-
echo "[WARNING] NODE_OPTIONS: $NODE_OPTIONS"
74+
# This is a temporary fix until we upgrade our toolkit to 24.11+
75+
# More info: https://github.com/mongodb-js/devtools-toolchain/pull/10
76+
export NODE_OPTIONS="$NODE_OPTIONS --jitless"
77+
echo "[WARNING] Using jitless v8."
78+
echo "[WARNING] NODE_OPTIONS: $NODE_OPTIONS"
7979
fi
8080
fi
8181

package-lock.json

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

scripts/run-if-package-requested.js

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,13 +8,12 @@ if (process.env.MONGOSH_RUN_ONLY_IN_PACKAGE && process.env.MONGOSH_RUN_ONLY_IN_P
88
return;
99
}
1010

11-
let parentEnv = process.env;
1211
if (process.version.startsWith("v24")) {
13-
parentEnv.NODE_OPTIONS = `${parentEnv.NODE_OPTIONS} --no-experimental-strip-types`;
12+
process.env.NODE_OPTIONS = `${parentEnv.NODE_OPTIONS ?? ''} --no-experimental-strip-types`;
1413
}
1514

1615
const child_process = require('child_process');
17-
child_process.spawn(process.argv[2], process.argv.slice(3), { stdio: 'inherit', shell: process.platform === 'win32', env: parentEnv })
16+
child_process.spawn(process.argv[2], process.argv.slice(3), { stdio: 'inherit', shell: process.platform === 'win32' })
1817
.on('exit', (code, signal) => {
1918
if (signal) {
2019
process.kill(process.pid, signal);

0 commit comments

Comments
 (0)