chore(cli-repl): clean up autocomplete implementation and fix flaky test MONGOSH-1908 MONGOSH-1960 #2317
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best viewed as a whitespace-diff-disabled change, doesn't include any functional work.
Our current autocomplete logic does not always wait for the collection or database name caches to be filled, in case it takes longer than 200ms to do so. By ensuring that the caches are filled before we run the test, we get consistent results.
Collection and database names, as well as other completion items, can mostly contain arbitrary characters with only a few exceptions. Since some characters may mess with our REPL input, we should filter those autocompletions out.
gagik
approved these changes
Jan 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(cli-repl): clean autocomplete implementation up a bit
Best viewed as a whitespace-diff-disabled change, doesn't include
any functional work.
chore(cli-repl): fix flaky autocompletion test MONGOSH-1960
Our current autocomplete logic does not always wait for the collection
or database name caches to be filled, in case it takes longer than 200ms
to do so. By ensuring that the caches are filled before we run the test,
we get consistent results.
chore(cli-repl,shell-api): filter autocompletions for CCs MONGOSH-1908
Collection and database names, as well as other completion items, can
mostly contain arbitrary characters with only a few exceptions.
Since some characters may mess with our REPL input, we should filter
those autocompletions out.