Skip to content

Conversation

@gagik
Copy link
Contributor

@gagik gagik commented Jan 28, 2025

bump-packages from monorepo-tools is looking for chore(ci): bump packages as the start of the commit to calculate the semver bump. The problem is that our commit message doesn't start with this - instead it's chore(release): bump auxiliary packages. This means that the next time we run it, we go back to the start of time and sure enough, we find some breaking: ... commit message and decide we need to bump major. Luckily there's a LAST_BUMP_COMMIT_MESSAGE we can use to set this, so this does that.

bump-packages from monorepo-tools is looking for chore(ci): bump packages as the start of the commit to calculate the semver bump. The problem is that our commit message doesn't start with this - instead it's chore(release): bump auxiliary packages. This means that the next time we run it, we go back to the start of time and sure enough, we find some breaking: ... commit message and decide we need to bump major. Luckily there's a LAST_BUMP_COMMIT_MESSAGE we can use to set this.
@gagik gagik added the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jan 28, 2025
@gagik gagik requested a review from nirinchev January 28, 2025 10:11
@gagik gagik removed the no-title-validation Skips validation of PR titles (conventional commit adherence + JIRA ticket inclusion) label Jan 28, 2025
@gagik gagik changed the title fix(ci): use the correct commit message when bumping packages fix(ci): use the correct commit message when bumping packages MONGOSH-1871 Jan 28, 2025
@gagik gagik merged commit 21c5d45 into main Jan 28, 2025
122 of 125 checks passed
@gagik gagik deleted the gagik/fix-bumping-packages branch January 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants