fix(release): add a bump step to draft and publish stages #2339
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
added
the
no-title-validation
gagik
force-pushed
the
gagik/fix-mongosh-versioning
branch
from
bb25f87 to
182268c
Compare
gagik
changed the title
addaleax
approved these changes
Jan 31, 2025
gagik
commented
Jan 31, 2025
| downloadArtifactFromEvergreen: typeof downloadArtifactFromEvergreenFn = downloadArtifactFromEvergreenFn, | ||
| ensureGithubReleaseExistsAndUpdateChangelog: typeof ensureGithubReleaseExistsAndUpdateChangelogFn = ensureGithubReleaseExistsAndUpdateChangelogFn | ||
| ensureGithubReleaseExistsAndUpdateChangelog: typeof ensureGithubReleaseExistsAndUpdateChangelogFn = ensureGithubReleaseExistsAndUpdateChangelogFn, | ||
| bumpMongoshReleasePackages: typeof bumpMongoshReleasePackagesFn = bumpMongoshReleasePackagesFn, |
Contributor
Author
There was a problem hiding this comment.
I am definitely getting rid of this structure of functions the moment I have a chance but for now... 😫
Collaborator
There was a problem hiding this comment.
Yeah, please feel very free to create a ticket for this 🙂
gagik
force-pushed
the
gagik/fix-mongosh-versioning
branch
from
b7a2595 to
c2285a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft release will bump mongosh + other packages and build a release but not persist
Publish release will also bump mongosh + other packages (there's an assumption that nothing happened between the draft => publish stage) and "persist" that in sense that it'll push a tag, and then we can make a PR to merge the tags' content into main.