fix(ci): use more resilient approach for installing docker test dependencies #2348
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dencies Our docker tests partially require `mongodb-crypt-library-version` to be present in `scripts/docker/node_modules`, installing it there directly and explicitly is more reliable than running `npm ci` in the monorepo root and copying `node_modules` over from there (esp. since `npm ci` may not work after packages have been bumped as part of a relase).
gagik
approved these changes
Feb 3, 2025
addaleax
added
the
no-title-validation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our docker tests partially require
mongodb-crypt-library-versionto be present inscripts/docker/node_modules, installing it there directly and explicitly is more reliable than runningnpm ciin the monorepo root and copyingnode_modulesover from there (esp. sincenpm cimay not work after packages have been bumped as part of a relase).