refactor(build): restructure build helpers to use classes MONGOSH-2007 #2374
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of the helper do dependency injection by using some of its arguments to optionally pass other (stubbed) helpers. This is getting out of hand and now we have things like:
To minimize this, this PR restructures these functions to be inside classes based on responsibility.
There are no real functionality changes beyond combining some helpers into a single class.
Some noteworthy changes:
push-tags=> combined withpublishinPackagePublishermarkBumpedFilesAsAssumeUnchangedwas completely removed as it was unused.For the sake of keeping this not larger than it already is, some helper functions were left the same and only more core ones were changed.
I am not changing the file names here so diffs can be more readable but it'd be worth doing that in a follow-up PR.