chore(ci): correctly pass args to mongodb-runner MONGOSH-2011 #2403
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Mar 10, 2025
Collaborator
addaleax
left a comment
addaleax
left a comment
There was a problem hiding this comment.
I assumed that npx would already handle this since it seems to do this locally, but maybe this works a bit differently on Windows?
(If this is about Windows-specific behavior, and this doesn't do the trick, it might also be worth explicitly setting the shell to bash for this command)
nirinchev
changed the title
Collaborator
Author
|
Yeah, it seems like this is only happening on Windows with node 22/23. I didn't test with bash (only pwsh) since I figured this is a good enough solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On windows with node 22/23, when running mongodb-runner with npx, the
--will be applied to npx command rather than the exec, so we need another set of dashes to make yargs happy.