chore(ci): skip chromium download for most tasks #2432
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gagik
force-pushed
the
gagik/puppeteer-experiment
branch
from
1286810 to
023021a
Compare
gagik
force-pushed
the
gagik/puppeteer-experiment
branch
from
d9ed8d1 to
4fdfe73
Compare
gagik
changed the title
gagik
added
the
no-title-validation
nirinchev
approved these changes
Apr 9, 2025
Collaborator
nirinchev
left a comment
nirinchev
left a comment
There was a problem hiding this comment.
That 30+ minute speedup on RHEL 😱
addaleax
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Out of experiencing the pain of seeing what seemed to be potentially a 10 minute download and install of puppeteer each time during release, I became curious whether we're actually skipping things correctly.
PUPPETEER_SKIP_DOWNLOADonly applies at a post-install script but in many places we set it after all dependencies have already been installed. This sets it at the install stage instead. Not sure whatever the issues were with #2311 would come up here, seems all good so far.Not super scientific but this leads to quicker execution on hosts which tend to not have the Chromium in their cache like RHEL:
Before
After